1. 26 6月, 2020 12 次提交
  2. 25 6月, 2020 21 次提交
  3. 24 6月, 2020 3 次提交
    • M
      trace/simple: Fix unauthorized enable · db25d56c
      Markus Armbruster 提交于
      st_set_trace_file() accidentally enables tracing.  It's called
      unconditionally during startup, which is why QEMU built with the
      simple trace backend always writes a trace file "trace-$PID".
      
      This has been broken for quite a while.  I didn't track down the exact
      commit.
      
      Fix st_set_trace_file() to restore the state.
      Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
      Reviewed-by: NPhilippe Mathieu-Daudé <philmd@redhat.com>
      Message-id: 20200527065613.25322-1-armbru@redhat.com
      Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      db25d56c
    • P
      scripts/tracetool: Update maintainer email address · f892b494
      Philippe Mathieu-Daudé 提交于
      There is an effort in progress to generate a QEMU Python
      package. As I'm not sure this old email is still valid,
      update it to not produce package with broken maintainer
      email.
      
      Patch created mechanically by running:
      
       $ sed -i 's,\(__email__ *= "\)stefanha@linux.vnet.ibm.com",\1stefanha@redhat.com",' \
               $(git grep -l 'email.*stefanha@linux.vnet.ibm.com')
      Signed-off-by: NPhilippe Mathieu-Daudé <philmd@redhat.com>
      Reviewed-by: NJohn Snow <jsnow@redhat.com>
      Message-id: 20200511082816.696-1-philmd@redhat.com
      Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      f892b494
    • P
      Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200623' into staging · d4b78317
      Peter Maydell 提交于
      target-arm queue:
       * util/oslib-posix : qemu_init_exec_dir implementation for Mac
       * target/arm: Last parts of neon decodetree conversion
       * hw/arm/virt: Add 5.0 HW compat props
       * hw/watchdog/cmsdk-apb-watchdog: Add trace event for lock status
       * mps2: Add CMSDK APB watchdog, FPGAIO block, S2I devices and I2C devices
       * mps2: Add some unimplemented-device stubs for audio and GPIO
       * mps2-tz: Use the ARM SBCon two-wire serial bus interface
       * target/arm: Check supported KVM features globally (not per vCPU)
       * tests/qtest/arm-cpu-features: Add feature setting tests
       * arm/virt: Add memory hot remove support
      
      # gpg: Signature made Tue 23 Jun 2020 12:38:31 BST
      # gpg:                using RSA key E1A5C593CD419DE28E8315CF3C2525ED14360CDE
      # gpg:                issuer "peter.maydell@linaro.org"
      # gpg: Good signature from "Peter Maydell <peter.maydell@linaro.org>" [ultimate]
      # gpg:                 aka "Peter Maydell <pmaydell@gmail.com>" [ultimate]
      # gpg:                 aka "Peter Maydell <pmaydell@chiark.greenend.org.uk>" [ultimate]
      # Primary key fingerprint: E1A5 C593 CD41 9DE2 8E83  15CF 3C25 25ED 1436 0CDE
      
      * remotes/pmaydell/tags/pull-target-arm-20200623: (42 commits)
        arm/virt: Add memory hot remove support
        tests/qtest/arm-cpu-features: Add feature setting tests
        target/arm: Check supported KVM features globally (not per vCPU)
        hw/arm/mps2-tz: Use the ARM SBCon two-wire serial bus interface
        hw/arm/mps2: Add audio I2S interface as unimplemented device
        hw/arm/mps2: Add I2C devices
        hw/arm/mps2: Add SPI devices
        hw/arm/mps2: Map the FPGA I/O block
        hw/arm/mps2: Add CMSDK AHB GPIO peripherals as unimplemented devices
        hw/arm/mps2: Add CMSDK APB watchdog device
        hw/arm/mps2: Rename CMSDK AHB peripheral region
        hw/arm/mps2: Document CMSDK/FPGA APB subsystem sections
        hw/arm: Use TYPE_VERSATILE_I2C instead of hardcoded string
        hw/i2c: Add header for ARM SBCon two-wire serial bus interface
        hw/i2c/versatile_i2c: Add SCL/SDA definitions
        hw/i2c/versatile_i2c: Add definitions for register addresses
        hw/watchdog/cmsdk-apb-watchdog: Add trace event for lock status
        target/arm: Remove dead code relating to SABA and UABA
        target/arm: Remove unnecessary gen_io_end() calls
        target/arm: Move some functions used only in translate-neon.inc.c to that file
        ...
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      d4b78317
  4. 23 6月, 2020 4 次提交
    • M
      sd/milkymist-memcard: Fix error API violation · 953cd661
      Markus Armbruster 提交于
      The Error ** argument must be NULL, &error_abort, &error_fatal, or a
      pointer to a variable containing NULL.  Passing an argument of the
      latter kind twice without clearing it in between is wrong: if the
      first call sets an error, it no longer points to NULL for the second
      call.
      
      milkymist_memcard_realize() is wrong that way: it passes &err to
      qdev_prop_set_drive_err() and qdev_realize_and_unref().  Currently
      harmless, because the latter uses it only as first argument of
      error_propagate().
      
      Making qdev_prop_set_drive_err() fail involves abuse of -global.
      Leave handling that to qdev_prop_set_drive(), like we do elsewhere.
      
      Cc: Michael Walle <michael@walle.cc>
      Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
      Message-Id: <20200622094227.1271650-17-armbru@redhat.com>
      Reviewed-by: NPhilippe Mathieu-Daudé <f4bug@amsat.org>
      953cd661
    • M
      sd/pxa2xx_mmci: Don't crash on pxa2xx_mmci_init() error · 17d26ac6
      Markus Armbruster 提交于
      On error, pxa2xx_mmci_init() reports to stderr and returns NULL.
      Callers don't check for errors.  Machines akita, borzoi, mainstone,
      spitz, terrier, tosa, and z2 crash shortly after, like this:
      
          $ qemu-system-aarch64 -M akita -drive if=sd,readonly=on
          qemu-system-aarch64: failed to init SD card: Cannot use read-only drive as SD card
          Segmentation fault (core dumped)
      
      Machines connex and verdex reach the check for orphaned drives first:
      
          $ aarch64-softmmu/qemu-system-aarch64 -M connex -drive if=sd,readonly=on -accel qtest
          qemu-system-aarch64: failed to init SD card: Cannot use read-only drive as SD card
          qemu-system-aarch64: -drive if=sd,readonly=on: machine type does not support if=sd,bus=0,unit=0
      
      Make pxa2xx_mmci_init() fail cleanly right away.
      
      Cc: Andrzej Zaborowski <balrogg@gmail.com>
      Cc: Peter Maydell <peter.maydell@linaro.org>
      Cc: qemu-arm@nongnu.org
      Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
      Reviewed-by: NPhilippe Mathieu-Daudé <philmd@redhat.com>
      Message-Id: <20200622094227.1271650-16-armbru@redhat.com>
      17d26ac6
    • M
      arm/aspeed: Drop aspeed_board_init_flashes() parameter @errp · c20b4ccc
      Markus Armbruster 提交于
      We always pass &error_abort.  Drop the parameter, use &error_abort
      directly.
      
      Cc: Cédric Le Goater <clg@kaod.org>
      Cc: Peter Maydell <peter.maydell@linaro.org>
      Cc: Andrew Jeffery <andrew@aj.id.au>
      Cc: Joel Stanley <joel@jms.id.au>
      Cc: qemu-arm@nongnu.org
      Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
      Reviewed-by: NCédric Le Goater <clg@kaod.org>
      Reviewed-by: NPhilippe Mathieu-Daudé <philmd@redhat.com>
      Message-Id: <20200622094227.1271650-15-armbru@redhat.com>
      c20b4ccc
    • M
      qdev: Make qdev_prop_set_drive() match the other helpers · 934df912
      Markus Armbruster 提交于
      qdev_prop_set_drive() can fail.  None of the other qdev_prop_set_FOO()
      can; they abort on error.
      
      To clean up this inconsistency, rename qdev_prop_set_drive() to
      qdev_prop_set_drive_err(), and create a qdev_prop_set_drive() that
      aborts on error.
      
      Coccinelle script to update callers:
      
          @ depends on !(file in "hw/core/qdev-properties-system.c")@
          expression dev, name, value;
          symbol error_abort;
          @@
          -    qdev_prop_set_drive(dev, name, value, &error_abort);
          +    qdev_prop_set_drive(dev, name, value);
      
          @@
          expression dev, name, value, errp;
          @@
          -    qdev_prop_set_drive(dev, name, value, errp);
          +    qdev_prop_set_drive_err(dev, name, value, errp);
      Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
      Reviewed-by: NPhilippe Mathieu-Daudé <philmd@redhat.com>
      Message-Id: <20200622094227.1271650-14-armbru@redhat.com>
      934df912