1. 28 1月, 2016 2 次提交
  2. 27 1月, 2016 9 次提交
    • P
      Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20160126-2' into staging · 39c36a05
      Peter Maydell 提交于
      Xen 2016/01/26 with Signed-off-by lines.
      
      # gpg: Signature made Tue 26 Jan 2016 17:20:12 GMT using RSA key ID 70E1AE90
      # gpg: Good signature from "Stefano Stabellini <stefano.stabellini@eu.citrix.com>"
      
      * remotes/sstabellini/tags/xen-20160126-2:
        xen: make it possible to build without the Xen PV domain builder
        xen: domainbuild: reopen libxenctrl interface after forking for domain watcher.
        xen: Use stable library interfaces when they are available.
        xen: Switch uses of xc_map_foreign_{pages,bulk} to use libxenforeignmemory API.
        xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages
        xen: Switch to libxengnttab interface for compat shims.
        xen: Switch to libxenevtchn interface for compat shims.
        xen_console: correctly cleanup primary console on teardown.
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      39c36a05
    • I
      xen: make it possible to build without the Xen PV domain builder · 64a7ad6f
      Ian Campbell 提交于
      Until the previous patch this relied on xc_fd(), which was only
      implemented for Xen 4.0 and earlier.
      
      Given this wasn't working since Xen 4.0 I have marked this as disabled
      by default.
      
      Removing this support drops the use of a bunch of symbols from
      libxenctrl, specifically:
      
        - xc_domain_create
        - xc_domain_destroy
        - xc_domain_getinfo
        - xc_domain_max_vcpus
        - xc_domain_setmaxmem
        - xc_domain_unpause
        - xc_evtchn_alloc_unbound
        - xc_linux_build
      
      This is another step towards only using Xen libraries which provide a
      stable inteface.
      Signed-off-by: NIan Campbell <ian.campbell@citrix.com>
      Reviewed-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      Signed-off-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      64a7ad6f
    • I
      xen: domainbuild: reopen libxenctrl interface after forking for domain watcher. · 228df5c9
      Ian Campbell 提交于
      Using an existing libxenctrl handle after a fork was never
      particularly safe (especially if foreign mappings existed at the time
      of the fork) and the xc fd has been unavailable for many releases.
      
      Reopen the handle after fork and therefore do away with xc_fd().
      Signed-off-by: NIan Campbell <ian.campbell@citrix.com>
      Acked-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      Signed-off-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      228df5c9
    • I
      xen: Use stable library interfaces when they are available. · 5eeb39c2
      Ian Campbell 提交于
      In Xen 4.7 we are refactoring parts libxenctrl into a number of
      separate libraries which will provide backward and forward API and ABI
      compatiblity.
      
      Specifically libxenevtchn, libxengnttab and libxenforeignmemory.
      
      Previous patches have already laid the groundwork for using these by
      switching the existing compatibility shims to reflect the intefaces to
      these libraries.
      
      So all which remains is to update configure to detect the libraries
      and enable their use. Although they are notionally independent we take
      an all or nothing approach to the three libraries since they were
      added at the same time.
      
      The only non-obvious bit is that we now open a proper xenforeignmemory
      handle for xen_fmem instead of reusing the xen_xc handle.
      
      Build tested with 4.0 .. 4.6 (inclusive) and the patches targetting
      4.7 which adds these libraries.
      
      This uses CONFIG_XEN_CTRL_INTERFACE_VERSION == 471 to cover the
      introduction of these new interfaces.
      Signed-off-by: NIan Campbell <ian.campbell@citrix.com>
      Reviewed-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      Signed-off-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      5eeb39c2
    • I
      xen: Switch uses of xc_map_foreign_{pages,bulk} to use libxenforeignmemory API. · e0cb42ae
      Ian Campbell 提交于
      In Xen 4.7 we are refactoring parts libxenctrl into a number of
      separate libraries which will provide backward and forward API and ABI
      compatiblity.
      
      One such library will be libxenforeignmemory which provides access to
      privileged foreign mappings and which will provide an interface
      equivalent to xc_map_foreign_{pages,bulk}.
      
      The new xenforeignmemory_map() function behaves like
      xc_map_foreign_pages() when the err argument is NULL and like
      xc_map_foreign_bulk() when err is non-NULL, which maps into the shim
      here onto checking err == NULL and calling the appropriate old
      function.
      
      Note that xenforeignmemory_map() takes the number of pages before the
      arrays themselves, in order to support potentially future use of
      variable-length-arrays in the prototype (in the future, when Xen's
      baseline toolchain requirements are new enough to ensure VLAs are
      supported).
      
      In preparation for adding support for libxenforeignmemory add support
      to the <=4.0 and <=4.6 compat code in xen_common.h to allow us to
      switch to using the new API. These shims will disappear for versions
      of Xen which include libxenforeignmemory.
      
      Since libxenforeignmemory will have its own handle type but for <= 4.6
      the functionality is provided by using a libxenctrl handle we
      introduce a new global xen_fmem alongside the existing xen_xc. In fact
      we make xen_fmem a pointer to the existing xen_xc, which then works
      correctly with both <=4.0 (xc handle is an int) and <=4.6 (xc handle
      is a pointer). In the latter case xen_fmem is actually a double
      indirect pointer, but it all falls out in the wash.
      
      Unlike libxenctrl libxenforeignmemory has an explicit unmap function,
      rather than just specifying that munmap should be used, so the unmap
      paths are updated to use xenforeignmemory_unmap, which is a shim for
      munmap on these versions of xen. The mappings in xen-hvm.c do not
      appear to be unmapped (which makes sense for a qemu-dm process)
      
      In fb_disconnect this results in a change from simply mmap over the
      existing mapping (with an implicit munmap) to expliclty unmapping with
      xenforeignmemory_unmap and then mapping the required anonymous memory
      in the same hole. I don't think this is a problem since any other
      thread which was racily touching this region would already be running
      the risk of hitting the mapping halfway through the call. If this is
      thought to be a problem then we could consider adding an extra API to
      the libxenforeignmemory interface to replace a foreign mapping with
      anonymous shared memory, but I'd prefer not to.
      Signed-off-by: NIan Campbell <ian.campbell@citrix.com>
      Reviewed-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      Signed-off-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      e0cb42ae
    • I
      xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages · 9ed257d1
      Ian Campbell 提交于
      In Xen 4.7 we are refactoring parts libxenctrl into a number of
      separate libraries which will provide backward and forward API and ABI
      compatiblity.
      
      One such library will be libxenforeignmemory which provides access to
      privileged foreign mappings and which will provide an interface
      equivalent to xc_map_foreign_{pages,bulk}.
      
      In preparation for this switch all uses of xc_map_foreign_range to
      xc_map_foreign_pages. This is trivial because size was always
      XC_PAGE_SIZE so the necessary adjustments are trivial:
      
        * Pass &mfn (an array of length 1) instead of mfn. The function
          takes a pointer to const, so there is no possibily of mfn changing
          due to this change.
        * Pass nr_pages=1 instead of size=XC_PAGE_SIZE
      
      There is one wrinkle in xen_console.c:con_initialise() where
      con->ring_ref is an int but can in some code paths (when !xendev->dev)
      be treated as an mfn. I think this is an existing latent truncation
      hazard on platforms where xen_pfn_t is 64-bit and int is 32-bit (e.g.
      amd64, both arm* variants). I'm unsure under what circumstances
      xendev->dev can be NULL or if anything elsewhere ensures the value
      fits into an int. For now I just use a temporary xen_pfn_t to in
      effect upcast the pointer from int* to xen_pfn_t*.
      
      In xenfb.c:common_bind we now explicitly launder the mfn into a
      xen_pfn_t, so it has the correct type to be passed to
      xc_map_foreign_pages and doesn't provoke warnings on 32-bit x86.
      Signed-off-by: NIan Campbell <ian.campbell@citrix.com>
      Reviewed-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      Signed-off-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      9ed257d1
    • I
      xen: Switch to libxengnttab interface for compat shims. · c1345a88
      Ian Campbell 提交于
      In Xen 4.7 we are refactoring parts libxenctrl into a number of
      separate libraries which will provide backward and forward API and ABI
      compatiblity.
      
      One such library will be libxengnttab which provides access to grant
      tables.
      
      In preparation for this switch the compatibility layer in xen_common.h
      (which support building with older versions of Xen) to use what will
      be the new library API. This means that the gnttab shim will disappear
      for versions of Xen which include libxengnttab.
      
      To simplify things for the <= 4.0.0 support we wrap the int fd in a
      malloc(sizeof int) such that the handle is always a pointer. This
      leads to less typedef headaches and the need for
      XC_HANDLER_INITIAL_VALUE etc for these interfaces.
      
      Note that this patch does not add any support for actually using
      libxengnttab, it just adjusts the existing shims.
      Signed-off-by: NIan Campbell <ian.campbell@citrix.com>
      Reviewed-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      Signed-off-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      c1345a88
    • I
      xen: Switch to libxenevtchn interface for compat shims. · a2db2a1e
      Ian Campbell 提交于
      In Xen 4.7 we are refactoring parts libxenctrl into a number of
      separate libraries which will provide backward and forward API and ABI
      compatiblity.
      
      One such library will be libxenevtchn which provides access to event
      channels.
      
      In preparation for this switch the compatibility layer in xen_common.h
      (which support building with older versions of Xen) to use what will
      be the new library API. This means that the evtchn shim will disappear
      for versions of Xen which include libxenevtchn.
      
      To simplify things for the <= 4.0.0 support we wrap the int fd in a
      malloc(sizeof int) such that the handle is always a pointer. This
      leads to less typedef headaches and the need for
      XC_HANDLER_INITIAL_VALUE etc for these interfaces.
      
      Note that this patch does not add any support for actually using
      libxenevtchn, it just adjusts the existing shims.
      
      Note that xc_evtchn_alloc_unbound functionality remains in libxenctrl,
      since that functionality is not exposed by /dev/xen/evtchn.
      Signed-off-by: NIan Campbell <ian.campbell@citrix.com>
      Reviewed-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      Signed-off-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      a2db2a1e
    • I
      xen_console: correctly cleanup primary console on teardown. · 549e9bca
      Ian Campbell 提交于
      All of the work in con_disconnect applies to the primary console case
      (when xendev->dev is NULL). Therefore remove the early check and bail
      and allow it to fall through. All of the existing code is correctly
      conditional already.
      
      The ->dev and ->gnttabdev handles are either both set or neither. For
      consistency with con_initialise() with to the former here too.
      
      With this con_initialise and con_disconnect now mirror each other.
      
      Fix up a hard tab in the function while editing.
      Signed-off-by: NIan Campbell <ian.campbell@citrix.com>
      Reviewed-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      Signed-off-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
      549e9bca
  3. 26 1月, 2016 29 次提交