1. 19 4月, 2012 4 次提交
  2. 19 3月, 2012 2 次提交
    • P
      scsi: copy serial number into VPD page 0x83 · fd930791
      Paolo Bonzini 提交于
      Currently QEMU passes the qdev device id to the guest in an ASCII-string
      designator in page 0x83.  While this is fine, it does not match what
      real hardware does; usually the ASCII-string designator there hosts
      another copy of the serial number (there can be other designators,
      for example with a world-wide name).  Do the same for QEMU SCSI
      disks.
      
      ATAPI does not support VPD pages, so it does not matter there.
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      fd930791
    • P
      scsi-cd: check ready condition before processing several commands · 9bcaf4fe
      Paolo Bonzini 提交于
      This commit is more or less obvious.  What it caused is less obvious:
      SCSI CD drives failed to eject under Linux, though for example the
      "change" command worked okay.  This happens because of the autoclose
      option in the Linux CD-ROM driver.
      
      The actual chain of events is quite complex and somehow involves
      udev helpers; the actual command that matters is READ TOC, though
      honestly it's not really clear to me how because it should always be
      invoked after autoclose, not before.
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      9bcaf4fe
  3. 24 2月, 2012 1 次提交
  4. 23 2月, 2012 2 次提交
  5. 22 2月, 2012 2 次提交
  6. 15 2月, 2012 1 次提交
  7. 04 2月, 2012 1 次提交
    • A
      qdev: register all types natively through QEMU Object Model · 39bffca2
      Anthony Liguori 提交于
      This was done in a mostly automated fashion.  I did it in three steps and then
      rebased it into a single step which avoids repeatedly touching every file in
      the tree.
      
      The first step was a sed-based addition of the parent type to the subclass
      registration functions.
      
      The second step was another sed-based removal of subclass registration functions
      while also adding virtual functions from the base class into a class_init
      function as appropriate.
      
      Finally, a python script was used to convert the DeviceInfo structures and
      qdev_register_subclass functions to TypeInfo structures, class_init functions,
      and type_register_static calls.
      
      We are almost fully converted to QOM after this commit.
      Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>
      39bffca2
  8. 28 1月, 2012 1 次提交
  9. 26 1月, 2012 1 次提交
  10. 06 1月, 2012 1 次提交
    • M
      scsi virtio-blk usb-msd: Clean up device init error messages · 6a84cb1f
      Markus Armbruster 提交于
      Replace
      
          error_report("DEVICE-NAME: MESSAGE");
      
      by just
      
          error_report("MESSAGE");
      
      in block device init functions.
      
      DEVICE-NAME is bogus in some cases: it's "scsi-disk" for device
      scsi-hd and scsi-cd, "virtio-blk-pci" for virtio-blk-s390, and
      "usb-msd" for usb-storage.
      
      There is no real need to put a device name in the message, because
      error_report() points to the offending command line option already:
      
      $ qemu-system-x86_64 --nodefaults --enable-kvm -vnc :0 -S -monitor stdio -usb -device virtio-blk-pci
      upstream-qemu: -device virtio-blk-pci: virtio-blk-pci: drive property not set
      upstream-qemu: -device virtio-blk-pci: Device 'virtio-blk-pci' could not be initialized
      
      And for a monitor command, it's obvious anyway:
      
      $ qemu-system-x86_64 --nodefaults --enable-kvm -vnc :0 -S -monitor stdio -usb
      (qemu) device_add virtio-blk-pci
      virtio-blk-pci: drive property not set
      Device 'virtio-blk-pci' could not be initialized
      Reported-by: NAmit Shah <amit.shah@redhat.com>
      Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
      Signed-off-by: NStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
      6a84cb1f
  11. 15 12月, 2011 1 次提交
    • P
      block: bdrv_aio_* do not return NULL · ad54ae80
      Paolo Bonzini 提交于
      Initially done with the following semantic patch:
      
      @ rule1 @
      expression E;
      statement S;
      @@
        E =
      (
         bdrv_aio_readv
      |  bdrv_aio_writev
      |  bdrv_aio_flush
      |  bdrv_aio_discard
      |  bdrv_aio_ioctl
      )
           (...);
      (
      - if (E == NULL) { ... }
      |
      - if (E)
          { <... S ...> }
      )
      
      which however missed the occurrence in block/blkverify.c
      (as it should have done), and left behind some unused
      variables.
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      ad54ae80
  12. 18 11月, 2011 6 次提交
  13. 11 11月, 2011 1 次提交
  14. 29 10月, 2011 16 次提交