1. 30 1月, 2013 1 次提交
    • L
      linux-user: correct msgrcv() · 79dd77de
      Laurent Vivier 提交于
      All parameters must be swapped before the call of do_msgrcv().
      
      Allow faked (debian fakeroot daemon) to work properly.
      
      WITHOUT this patch:
      
      $ faked-sysv --foreground --debug
      using 1723744788 as msg key
      msg_key=1723744788
      1723744788:431
      FAKEROOT: msg=131072, key=1723744788
      FAKEROOT: r=-1, received message type=-150996052, message=-160219330
      FAKEROOT, get_msg: Bad address
      r=14, EINTR=4
      fakeroot: clearing up message queues and semaphores, signal=-1
      fakeroot: database save FAILED
      
      WITH this patch:
      
      $ faked-sysv --foreground --debug
      using 1569385744 as msg key
      msg_key=1569385744
      1569385744:424
      FAKEROOT: msg=0, key=1569385744
      ^C
      fakeroot: clearing up message queues and semaphores, signal=2
      fakeroot: database save FAILED
      Signed-off-by: NLaurent Vivier <laurent@vivier.eu>
      Reviewed-by: NPeter Maydell <peter.maydell@linaro.org>
      79dd77de
  2. 26 1月, 2013 1 次提交
  3. 25 1月, 2013 1 次提交
  4. 24 1月, 2013 5 次提交
    • M
      Revert "serial: fix retry logic" · b37a2e45
      Michael Tokarev 提交于
      This reverts commit 67c5322d:
      
          I'm not sure if the retry logic has ever worked when not using FIFO mode.  I
          found this while writing a test case although code inspection confirms it is
          definitely broken.
      
          The TSR retry logic will never actually happen because it is guarded by an
          'if (s->tsr_rety > 0)' but this is the only place that can ever make the
          variable greater than zero.  That effectively makes the retry logic an 'if (0)
      
          I believe this is a typo and the intention was >= 0.  Once this is fixed thoug
          I see double transmits with my test case.  This is because in the non FIFO
          case, serial_xmit may get invoked while LSR.THRE is still high because the
          character was processed but the retransmit timer was still active.
      
          We can handle this by simply checking for LSR.THRE and returning early.  It's
          possible that the FIFO paths also need some attention.
      
          Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
      Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>
      
      Even if the previous logic was never worked, new logic breaks stuff -
      namely,
      
       qemu -enable-kvm -nographic -kernel /boot/vmlinuz-$(uname -r) -append console=ttyS0 -serial pty
      
      the above command will cause the virtual machine to stuck at startup
      using 100% CPU till one connects to the pty and sends any char to it.
      
      Note this is rather typical invocation for various headless virtual
      machines by libvirt.
      
      So revert this change for now, till a better solution will be found.
      Signed-off-by: NMichael Tokarev <mjt@tls.msk.ru>
      Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>
      b37a2e45
    • P
      iscsi: add support for iovectors · 7371d56f
      Peter Lieven 提交于
      This patch adds support for directly passing the iovec
      array from QEMUIOVector if libiscsi supports it (1.8.0
      or newer).
      Signed-off-by: NPeter Lieven <pl@kamp.de>
      [Preserve the improvements from commit 4cc841b5, iscsi: partly
       avoid iovec linearization in iscsi_aio_writev, 2012-11-19 - Paolo]
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      7371d56f
    • P
      iscsi: do not leak acb->buf when commands are aborted · 4790b03d
      Paolo Bonzini 提交于
      acb->buf is freed in the WRITE(16) callback, but this may not
      get called at all when commands are aborted.  Add another
      free in the ABORT TASK callback, which requires setting acb->buf
      to NULL everywhere.
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      4790b03d
    • A
      target-cris: Fix typo in D_LOG() macro · 3f668b6c
      Andreas Färber 提交于
      It's __VA_ARGS__. Fixes the build with CRIS_[OP_]HELPER_DEBUG defined.
      
      Broken since r6338 / 93fcfe39 (Convert
      references to logfile/loglevel to use qemu_log*() macros).
      
      Cc: Eduardo Habkost <ehabkost@redhat.com>
      Signed-off-by: NAndreas Färber <afaerber@suse.de>
      Signed-off-by: NEdgar E. Iglesias <edgar.iglesias@gmail.com>
      3f668b6c
    • G
      trivial: etraxfs_eth: Eliminate checkpatch errors · 9fc7577a
      Grant Likely 提交于
      This is a trivial patch to harmonize the coding style on
      hw/etraxfs_eth.c. This is in preparation to split off the bitbang mdio
      code into a separate file.
      
      Cc: Peter Maydell <peter.maydell@linaro.org>
      Cc: Paul Brook <paul@codesourcery.com>
      Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
      Cc: Anthony Liguori <aliguori@us.ibm.com>
      Cc: Andreas Färber <afaerber@suse.de>
      Signed-off-by: NGrant Likely <grant.likely@secretlab.ca>
      Signed-off-by: NEdgar E. Iglesias <edgar.iglesias@gmail.com>
      9fc7577a
  5. 23 1月, 2013 3 次提交
  6. 22 1月, 2013 23 次提交
  7. 21 1月, 2013 6 次提交