提交 · 7157e2e23e89adcd436caeab31fdd6b47eded377 · openeuler / qemu

12 6月, 2011 40 次提交

virtio: guard against negative vq notifies · 7157e2e2

由 Stefan Hajnoczi 提交于 5月 08, 2011

The virtio_queue_notify() function checks that the virtqueue number is
less than the maximum number of virtqueues. A signed comparison is used
but the virtqueue number could be negative if a buggy or malicious guest
is run. This results in memory accesses outside of the virtqueue array.

It is risky doing input validation in common code instead of at the
guest<->host boundary. Note that virtio_queue_set_addr(),
virtio_queue_get_addr(), virtio_queue_get_num(), and many other virtio
functions do *not* validate the virtqueue number argument.

Instead of fixing the comparison in virtio_queue_notify(), move the
comparison to the virtio bindings (just like VIRTIO_PCI_QUEUE_SEL) where
we have a uint32_t value and can avoid ever calling into common virtio
code if the virtqueue number is invalid.
Signed-off-by: NStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

7157e2e2

virtio-pci.c: convert to PCIDEviceInfo to initialize ids · e75ccf2c

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

e75ccf2c

hw/xio3130_upstream.c: convert to PCIDeviceInfo to initialize ids · 5844997a

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

5844997a

hw/xio3130_downstream.c: convert to PCIDeviceInfo to initialize ids · 3ec39b2d

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

3ec39b2d

hw/wdt_i6300esb.c: convert to PCIDeviceInfo to initialize ids · 24b856ca

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

24b856ca

hw/vt82c686.c: convert to PCIDeviceInfo to initialize ids · 1cf0d2b8

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

1cf0d2b8

hw/vga-pci.c: convert to PCIDeviceInfo to initialize ids · 32902772

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

32902772

hw/versatile_pci.c: convert to PCIDeviceInfo to initialize ids · 56fe6408

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

56fe6408

hw/usb-ohci.c: convert to PCIDeviceInfo to initialize ids · a8eae585

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

a8eae585

hw/unin_pci.c: convert to PCIDeviceInfo to initialize ids · d7b61ecc

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

d7b61ecc

hw/sun4u.c: convert to PCIDeviceInfo to initialize ids · e8b36ba9

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

e8b36ba9

hw/sh_pci.c: convert to PCIDeviceInfo to initialize ids · ae2ebad7

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

ae2ebad7

hw/rtl8139.c: convert to PCIDeviceInfo to initialize ids · 7cba16a7

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

7cba16a7

hw/qxl.c: convert to PCIDeviceInfo to initialize ids · 96c05abc

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

96c05abc

hw/piix_pci.c: convert to PCIDeviceInfo to initialize ids · 3a9d8549

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

3a9d8549

hw/piix4.c: convert to PCIDeviceInfo to initialize ids · 146beee5

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

146beee5

hw/pcnet-pci.c: convert to PCIDeviceInfo to initialize ids · d7dccd11

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

d7dccd11

hw/ne2000.c: convert to PCIDeviceInfo to initialize ids · 18f1c729

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

18f1c729

hw/lsi53c895a.c: convert to PCIDeviceInfo to initialize ids · af5374aa

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

af5374aa

hw/ivshmem.c: convert to PCIDeviceInfo to initialize ids · 7aff0f21

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

7aff0f21

hw/ioh3420.c: convert to PCIDeviceInfo to initialize ids · 3d0b1e70

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

3d0b1e70

hw/intel-hda.c: convert to PCIDeviceInfo to initialize ids · d15fda63

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

d15fda63

hw/ide/via.c: convert to PCIDeviceInfo to initialize ids · 65ff544b

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

65ff544b

hw/ide/ich.c: convert to PCIDeviceInfo to initialize ids · 03f1c143

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

03f1c143

hw/ide/cmd646.c: convert to PCIDeviceInfo to initialize ids · c04ca075

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

c04ca075

hw/gt64xxx.c: convert to PCIDeviceInfo to initialize ids · 231f5f43

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

231f5f43

hw/grackle_pci.c: convert to PCIDeviceInfo to initialize ids · a614f52d

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

a614f52d

hw/es1370.c: convert to PCIDeviceInfo to initialize ids · 0b8c537f

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

0b8c537f

hw/e1000.c: convert to PCIDeviceInfo to initialize ids · e72d5c9d

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

e72d5c9d

hw/cirrus_vga.c: convert to PCIDeviceInfo to initialize ids · 5b96d8f9

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

5b96d8f9

hw/bonito.c: convert to PCIDeviceInfo to initialize ids · 51387f86

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

51387f86

hw/acpi_piix4.c: convert to PCIDeviceInfo to initialize ids · 580b7295

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

580b7295

hw/ac97.c: convert to PCIDeviceInfo to initialize ids · 0647b949

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

0647b949

vmware_vga.c: convert to PCIDeviceInfo to initialize ids · 310faaed

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

310faaed

ide/piix: convert to PCIDeviceInfo to initialize ids · 25f8e2f5

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

25f8e2f5

apb_pci: convert to PCIDeviceInfo to initialize ids · 92f9a4f1

由 Isaku Yamahata 提交于 5月 25, 2011

Use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

92f9a4f1

dec_pci: convert to PCIDeviceInfo to initialize ids · e7b9bc3e

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

e7b9bc3e

eepro100: convert to PCIDeviceInfo to initialize ids · ad03502b

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

ad03502b

usb-uhci: convert to PCIDEviceInfo to initialize ids · dc638fad

由 Isaku Yamahata 提交于 5月 25, 2011

use PCIDeviceInfo to initialize ids.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

dc638fad

pci: move ids of config space into PCIDeviceInfo · 113f89df

由 Isaku Yamahata 提交于 5月 25, 2011

vender id/device id... in configuration space are read-only registers
which are commonly defined for all pci devices.
So move those initialization into common place.
Signed-off-by: NIsaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>

113f89df