1. 03 5月, 2009 1 次提交
  2. 01 5月, 2009 24 次提交
  3. 30 4月, 2009 2 次提交
  4. 29 4月, 2009 3 次提交
  5. 28 4月, 2009 6 次提交
  6. 26 4月, 2009 2 次提交
  7. 25 4月, 2009 2 次提交
    • B
      48e77a36
    • I
      sparc64 support TSB related MMU registers · 697a77e6
      Igor Kovalenko 提交于
      Posting updated patch to the list...
      
      >>> On Fri, Apr 24, 2009 at 9:42 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
      >>>  >
      >>>  > Nice, though I didn't notice any visible improvement in my tests.
      
      > >>> This early in boot process there is not much to output; and I test
      > >>>  recent kernel which may use different startup sequence.
      > >>>  I modified openbios cif handler to output arguments and I now can see
      > >>>  visible difference.
      
      
      > >>>  >
      > >>>  > About the patch, there are a few problems:
      > >>>  > - it breaks Sparc32
      
      >>> You mean it stops working?
      >>
      >> Does not even build.
      
      Fixed now.
      
      >>>  > - commented out code is ugly
      >>>  > - if and else should be on the same line as '{' or '}'
      >>>  > - long lines should be wrapped
      >>>  > - in the line:
      >>>  > +    return (((tag_access_register & 0x1fff)<<48)|(tag_access_register >> 22));
      >>>  >  there should be white space between ) and << and 48.
      >>>  >
      >>>
      
      >>
      >> Also the ")|(" in between is crowded.
      >>
      >> Maybe the coding style does not describe this well enough.
      
      BTW Supplying indent template would be great.
      
      Please see the updated patch qemu-sparc64-tsb-asi-2.patch attached.
      
      --
      Kind regards,
      Igor V. Kovalenko
      697a77e6