1. 15 3月, 2017 1 次提交
    • P
      hw/misc/imx6_src: Don't crash trying to reset missing CPUs · 5e2fb7c5
      Peter Maydell 提交于
      Commit 4881658a introduced a call to arm_get_cpu_by_id(),
      and Coverity noticed that we weren't checking that it didn't
      return NULL (CID 1371652).
      
      Normally this won't happen (because all 4 CPUs are expected
      to exist), but it's possible the user requested fewer CPUs
      on the command line. Handle this possibility by silently
      doing nothing, which is the same behaviour as before commit
      4881658a and also how we handle the other CPU operations
      (since we ignore the INVALID_PARAM returns from arm_set_cpu_on()
      and friends).
      
      There is a slight behavioural difference to the pre-4881658a
      situation: the "reset this core" bit will remain set rather
      than not being permitted to be set. The imx6 datasheet is
      unclear about the behaviour in this odd corner case, so we
      opt for the simpler code rather than complicated logic to
      maintain identical behaviour.
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      Message-id: 1488542374-1256-1-git-send-email-peter.maydell@linaro.org
      Reviewed-by: NAlex Bennée <alex.bennee@linaro.org>
      5e2fb7c5
  2. 14 3月, 2017 3 次提交
  3. 09 3月, 2017 4 次提交
  4. 07 3月, 2017 6 次提交
  5. 06 3月, 2017 9 次提交
  6. 05 3月, 2017 1 次提交
    • M
      qapi: Make input visitors detect unvisited list tails · a4a1c70d
      Markus Armbruster 提交于
      Fix the design flaw demonstrated in the previous commit: new method
      check_list() lets input visitors report that unvisited input remains
      for a list, exactly like check_struct() lets them report that
      unvisited input remains for a struct or union.
      
      Implement the method for the qobject input visitor (straightforward),
      and the string input visitor (less so, due to the magic list syntax
      there).  The opts visitor's list magic is even more impenetrable, and
      all I can do there today is a stub with a FIXME comment.  No worse
      than before.
      Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
      Message-Id: <1488544368-30622-26-git-send-email-armbru@redhat.com>
      Reviewed-by: NEric Blake <eblake@redhat.com>
      a4a1c70d
  7. 03 3月, 2017 5 次提交
  8. 02 3月, 2017 11 次提交
反馈
建议
客服 返回
顶部