1. 16 1月, 2020 27 次提交
  2. 15 1月, 2020 1 次提交
    • P
      Merge remote-tracking branch 'remotes/kraxel/tags/ui-20200114-pull-request' into staging · 3a63b24a
      Peter Maydell 提交于
      ui: add "-display help", gtk refresh rate.
      
      # gpg: Signature made Tue 14 Jan 2020 10:01:14 GMT
      # gpg:                using RSA key 4CB6D8EED3E87138
      # gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
      # gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
      # gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
      # Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138
      
      * remotes/kraxel/tags/ui-20200114-pull-request:
        display/gtk: get proper refreshrate
        ui: Print available display backends with '-display help'
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      3a63b24a
  3. 14 1月, 2020 6 次提交
    • P
      Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging · fee0ec1f
      Peter Maydell 提交于
      Pull request
      
      # gpg: Signature made Tue 14 Jan 2020 09:30:45 GMT
      # gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
      # gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>" [full]
      # gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>" [full]
      # Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8
      
      * remotes/stefanha/tags/block-pull-request:
        linux-aio: increasing MAX_EVENTS to a larger hardcoded value
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      fee0ec1f
    • P
      Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging · 29234ded
      Peter Maydell 提交于
      Pull request
      
      # gpg: Signature made Tue 14 Jan 2020 09:29:11 GMT
      # gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
      # gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>" [full]
      # gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>" [full]
      # Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8
      
      * remotes/stefanha/tags/tracing-pull-request:
        trace: update qemu-trace-stap to Python 3
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      29234ded
    • N
      display/gtk: get proper refreshrate · c4c00922
      Nikola Pavlica 提交于
      Because some VMs in QEMU can get GPU virtualization (using technologies
      such as iGVT-g, as mentioned previously), they could produce a video
      output that had a higher display refresh rate than of what the GTK
      display was displaying. (fxp. Playing a video game inside of a Windows
      VM at 60 Hz, while the output stood locked at 33 Hz because of defaults
      set in include/ui/console.h)
      
      Since QEMU does indeed have internal systems for determining frame
      times as defined in ui/console.c.
      The code checks for a variable called update_interval that it later
      uses for time calculation. This variable, however, isn't defined
      anywhere in ui/gtk.c and instead ui/console.c just sets it to
      GUI_REFRESH_INTERVAL_DEFAULT which is 30
      
      update_interval represents the number of milliseconds per display
      refresh, and by doing some math we get that 1000/30 = 33.33... Hz
      
      This creates the mentioned problem and what this patch does is that it
      checks for the display refresh rate reported by GTK itself (we can take
      this as a safe value) and just converts it back to a number of
      milliseconds per display refresh.
      Signed-off-by: NNikola Pavlica <pavlica.nikola@gmail.com>
      Reviewed-by: NPhilippe Mathieu-Daudé <philmd@redhat.com>
      Message-id: 20200108121342.29597-1-pavlica.nikola@gmail.com
      
      [ kraxel: style tweak: add blank line between vars and code ]
      Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      c4c00922
    • T
      ui: Print available display backends with '-display help' · c388f408
      Thomas Huth 提交于
      We already print availabled devices with "-device help", or available
      backends with "-netdev help" or "-chardev help". Let's provide a way
      for the users to query the available display backends, too.
      Reviewed-by: NPhilippe Mathieu-Daudé <philmd@redhat.com>
      Tested-by: NPhilippe Mathieu-Daudé <philmd@redhat.com>
      Signed-off-by: NThomas Huth <thuth@redhat.com>
      Message-id: 20200108144702.29969-1-thuth@redhat.com
      Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      c388f408
    • S
      trace: update qemu-trace-stap to Python 3 · 3f009716
      Stefan Hajnoczi 提交于
      qemu-trace-stap does not support Python 3 yet:
      
        $ scripts/qemu-trace-stap list path/to/qemu-system-x86_64
        Traceback (most recent call last):
          File "scripts/qemu-trace-stap", line 175, in <module>
            main()
          File "scripts/qemu-trace-stap", line 171, in main
            args.func(args)
          File "scripts/qemu-trace-stap", line 118, in cmd_list
            print_probes(args.verbose, "*")
          File "scripts/qemu-trace-stap", line 114, in print_probes
            if line.startswith(prefix):
        TypeError: startswith first arg must be bytes or a tuple of bytes, not str
      
      Now that QEMU requires Python 3.5 or later we can switch to pure Python
      3.  Use Popen()'s universal_newlines=True argument to treat stdout as
      text instead of binary.
      
      Fixes: 62dd1048 ("trace: add ability to do simple printf logging via systemtap")
      Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1787395Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com>
      Message-id: 20200107112438.383958-1-stefanha@redhat.com
      Message-Id: <20200107112438.383958-1-stefanha@redhat.com>
      Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      3f009716
    • W
      linux-aio: increasing MAX_EVENTS to a larger hardcoded value · 2558cb8d
      Wangyong 提交于
      Since commit 6040aedd "virtio-blk:
      make queue size configurable",if the user set the queue size to
      more than 128 ,it will not take effect. That's because linux aio's
      maximum outstanding requests at a time is always less than or equal
      to 128.
      
      This patch simply increase MAX_EVENTS to a larger hardcoded value of
      1024 as a shortterm fix.
      Signed-off-by: Nwangyong <wang.yongD@h3c.com>
      Message-id: faa5781afd354a96a0be152b288f636f@h3c.com
      Message-Id: <faa5781afd354a96a0be152b288f636f@h3c.com>
      Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      2558cb8d
  4. 13 1月, 2020 6 次提交
    • P
      Merge remote-tracking branch 'remotes/kraxel/tags/usb-20200113-pull-request' into staging · 3c8a6575
      Peter Maydell 提交于
      usb: bugfixes for xhci, usb pass-through and usb redirection.
      
      # gpg: Signature made Mon 13 Jan 2020 13:06:35 GMT
      # gpg:                using RSA key 4CB6D8EED3E87138
      # gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
      # gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
      # gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
      # Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138
      
      * remotes/kraxel/tags/usb-20200113-pull-request:
        xhci: recheck slot status
        xhci: Fix memory leak in xhci_kick_epctx when poweroff GuestOS
        usbredir: Prevent recursion in usbredir_write
        usb-redir: remove 'remote wakeup' flag from configuration descriptor
        usb-host: remove 'remote wakeup' flag from configuration descriptor
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      3c8a6575
    • P
      Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-01-12' into staging · 981c9b88
      Peter Maydell 提交于
      * Move qtests into a separate directory
      * Build index.html for docs
      
      # gpg: Signature made Sun 12 Jan 2020 11:21:41 GMT
      # gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
      # gpg:                issuer "thuth@redhat.com"
      # gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
      # gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
      # gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
      # gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
      # Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5
      
      * remotes/huth-gitlab/tags/pull-request-2020-01-12:
        docs: build an index page for the HTML docs
        tests/libqos: Move the libqos files under tests/qtest/
        tests/Makefile: Move qtest-related settings to a separate Makefile.include
        test: Move qtests to a separate directory
        tests/Makefile: Separate unit test dependencies from qtest dependencies
        tests/Makefile: Remove 'tests/' and '$(EXESUF)' from the check-qtest variables
        tests/ptimer: Remove unnecessary inclusion of libqtest.h
        tests/Makefile: test-char does not need libqtest
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      981c9b88
    • G
      xhci: recheck slot status · 236846a0
      Gerd Hoffmann 提交于
      Factor out slot status check into a helper function.  Add an additional
      check after completing transfers.  This is needed in case a guest
      queues multiple transfers in a row and a device unplug happens while
      qemu processes them.
      
      Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1786413Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      Reviewed-by: NPhilippe Mathieu-Daudé <philmd@redhat.com>
      Message-id: 20200107083606.12393-1-kraxel@redhat.com
      236846a0
    • C
      xhci: Fix memory leak in xhci_kick_epctx when poweroff GuestOS · 34b9d6a1
      Chen Qun 提交于
      start vm with libvirt, when GuestOS running, enter poweroff command using
      the xhci keyboard, then ASAN shows memory leak stack:
      
      Direct leak of 80 byte(s) in 5 object(s) allocated from:
          #0 0xfffd1e6431cb in __interceptor_malloc (/lib64/libasan.so.4+0xd31cb)
          #1 0xfffd1e107163 in g_malloc (/lib64/libglib-2.0.so.0+0x57163)
          #2 0xaaad39051367 in qemu_sglist_init /qemu/dma-helpers.c:43
          #3 0xaaad3947c407 in pci_dma_sglist_init /qemu/include/hw/pci/pci.h:842
          #4 0xaaad3947c407 in xhci_xfer_create_sgl /qemu/hw/usb/hcd-xhci.c:1446
          #5 0xaaad3947c407 in xhci_setup_packet /qemu/hw/usb/hcd-xhci.c:1618
          #6 0xaaad3948625f in xhci_submit /qemu/hw/usb/hcd-xhci.c:1827
          #7 0xaaad3948625f in xhci_fire_transfer /qemu/hw/usb/hcd-xhci.c:1839
          #8 0xaaad3948625f in xhci_kick_epctx /qemu/hw/usb/hcd-xhci.c:1991
          #9 0xaaad3948f537 in xhci_doorbell_write /qemu/hw/usb/hcd-xhci.c:3158
          #10 0xaaad38bcbfc7 in memory_region_write_accessor /qemu/memory.c:483
          #11 0xaaad38bc654f in access_with_adjusted_size /qemu/memory.c:544
          #12 0xaaad38bd1877 in memory_region_dispatch_write /qemu/memory.c:1482
          #13 0xaaad38b1c77f in flatview_write_continue /qemu/exec.c:3167
          #14 0xaaad38b1ca83 in flatview_write /qemu/exec.c:3207
          #15 0xaaad38b268db in address_space_write /qemu/exec.c:3297
          #16 0xaaad38bf909b in kvm_cpu_exec /qemu/accel/kvm/kvm-all.c:2383
          #17 0xaaad38bb063f in qemu_kvm_cpu_thread_fn /qemu/cpus.c:1246
          #18 0xaaad39821c93 in qemu_thread_start /qemu/util/qemu-thread-posix.c:519
          #19 0xfffd1c8378bb  (/lib64/libpthread.so.0+0x78bb)
          #20 0xfffd1c77616b  (/lib64/libc.so.6+0xd616b)
      Reported-by: NEuler Robot <euler.robot@huawei.com>
      Signed-off-by: NChen Qun <kuhn.chenqun@huawei.com>
      Message-id: 20200110105855.81144-1-kuhn.chenqun@huawei.com
      Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      34b9d6a1
    • D
      usbredir: Prevent recursion in usbredir_write · 394642a8
      Dr. David Alan Gilbert 提交于
      I've got a case where usbredir_write manages to call back into itself
      via spice; this patch causes the recursion to fail (0 bytes) the write;
      this seems to avoid the deadlock I was previously seeing.
      
      I can't say I fully understand the interaction of usbredir and spice;
      but there are a few similar guards in spice and usbredir
      to catch other cases especially onces also related to spice_server_char_device_wakeup
      
      This case seems to be triggered by repeated migration+repeated
      reconnection of the viewer; but my debugging suggests the migration
      finished before this hits.
      
      The backtrace of the hang looks like:
        reds_handle_ticket
        reds_handle_other_links
        reds_channel_do_link
        red_channel_connect
        spicevmc_connect
        usbredir_create_parser
        usbredirparser_do_write
        usbredir_write
        qemu_chr_fe_write
        qemu_chr_write
        qemu_chr_write_buffer
        spice_chr_write
        spice_server_char_device_wakeup
        red_char_device_wakeup
        red_char_device_write_to_device
        vmc_write
        usbredirparser_do_write
        usbredir_write
        qemu_chr_fe_write
        qemu_chr_write
        qemu_chr_write_buffer
        qemu_mutex_lock_impl
      
      and we fail as we lang through qemu_chr_write_buffer's lock
      twice.
      
      Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1752320Signed-off-by: NDr. David Alan Gilbert <dgilbert@redhat.com>
      Message-Id: <20191218113012.13331-1-dgilbert@redhat.com>
      Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      394642a8
    • P
      Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-pull-request' into staging · abd5f8bb
      Peter Maydell 提交于
      Fix some uninitialized variable warnings,
      some memory leak warnings and update MAINTAINERS file.
      
      # gpg: Signature made Wed 08 Jan 2020 16:02:11 GMT
      # gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
      # gpg:                issuer "laurent@vivier.eu"
      # gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
      # gpg:                 aka "Laurent Vivier <laurent@vivier.eu>" [full]
      # gpg:                 aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" [full]
      # Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C
      
      * remotes/vivier2/tags/trivial-branch-pull-request:
        vl: fix memory leak in configure_accelerators
        arm/translate-a64: fix uninitialized variable warning
        nbd: fix uninitialized variable warning
        util/module: fix a memory leak
        MAINTAINERS: Update Yuval Shaia's email address
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      abd5f8bb