Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Only because qemu's checkpatch complains about it.
Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Using g_debug with log domain libcacard
Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Adds todos.
Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

We don't support T=1 so we shouldn't advertise it by default.

Two independent changes:
* Default ATR
 sets T=0. This gets overwritten by the client provided ATR later.
* Class descriptor
 changes dwAdvertise dwProtocols.PPPP to 0x1 and dwProtocols.RRRR=0 per spec.
Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Introduces a new utility function: parse_debug_env to avoid code
duplication.

This overrides whatever debug value is set on the corresponding devices
from the command line, and is meant to ease the usage with any
management stack. For libvirt you can set environment variables by
extending the dom namespace, i.e:

<domain type='kvm' id='3' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'>
  <qemu:commandline>
    <qemu:env name='QEMU_CCID_PASSTHRU_DEBUG' value='4'/>
    <qemu:env name='QEMU_CCID_DEBUG' value='4'/>
  </qemu:commandline>
</domain>
Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

By not advertising USB wakeup support (which we don't).
Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Signed-off-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Use only the modules defined in the NSS database.
Signed-off-by: NMarc-André Lureau <mlureau@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>

For some reason, with sql:/ prefix, the PKCS11 modules are not loaded.

This patch goes on top of Alon smartcard series.
Signed-off-by: NMarc-André Lureau <mlureau@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>

This version handles non-blocking sending and receiving from the
socket.
Signed-off-by: NMarc-André Lureau <mlureau@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>

Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>

Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>

Compile and link with version.lo
Signed-off-by: NMarc-André Lureau <mlureau@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>

It is needed to give that flag to the linker as well, but latest
libtool 2.4.2 still swallows that argument, so let's pass it with
libtool -Wc argument.

qemu-1.4.0/stubs/arch-query-cpu-def.c:6: undefined reference to `__stack_chk_guard'
Signed-off-by: NMarc-André Lureau <mlureau@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>

vscclient needs to call socket_init() for portability.
Moving to osdep.c since it has no internal dependency.
Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>

It's a bit nicer to look for default database under
CSIDL_COMMON_APPDATA\pki\nss rather that /etc/pki/nss.
Signed-off-by: NMarc-André Lureau <mlureau@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>

Signed-off-by: NJim Meyering <meyering@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Signed-off-by: NJim Meyering <meyering@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>
Reviewed-by: NMarc-André Lureau <mlureau@redhat.com>

Program received signal SIGSEGV, Segmentation fault.
__strcmp_sse42 () at ../sysdeps/x86_64/multiarch/strcmp-sse42.S:164
164               movdqu        (%rsi), %xmm2
(gdb) bt
    at /home/elmarco/320g/src/qemu/hw/ccid-card-emulated.c:477
    at /home/elmarco/320g/src/qemu/hw/ccid-card-emulated.c:503
Signed-off-by: NMarc-André Lureau <mlureau@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>

The VCARD_ATR_PREFIX macro adds a prefix of 6 characters only.

pcsc_scan was complaining before the patch:

+ Historical bytes: 56 43 41 52 44 5F 4E 53 53
 ERROR! ATR is truncated: 2 byte(s) is/are missing
Signed-off-by: NMarc-André Lureau <mlureau@redhat.com>
Reviewed-by: NAlon Levy <alevy@redhat.com>

Move the TPM passthrough specific command line options to the passthrough
backend implementation and attach them to the backend's interface structure.

Add code to tpm.c for validating the TPM command line options.
Signed-off-by: NStefan Berger <stefanb@linux.vnet.ibm.com>
Reviewed-by: NCorey Bryan <coreyb@linux.vnet.ibm.com>
Message-id: 1366641699-21420-1-git-send-email-stefanb@linux.vnet.ibm.com
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>

As the virtio-9p-pci is switched to the new API, we can use QOM casts.
Signed-off-by: NKONRAD Frederic <fred.konrad@greensocs.com>
Message-id: 1366708123-19626-5-git-send-email-fred.konrad@greensocs.com
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>

This remove old init function as it is no longer needed.
Signed-off-by: NKONRAD Frederic <fred.konrad@greensocs.com>
Message-id: 1366708123-19626-4-git-send-email-fred.konrad@greensocs.com
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>

Here the virtio-9p-pci is modified for the new API. The device
virtio-9p-pci extends virtio-pci. It creates and connects a
virtio-9p-device during the init. The properties are not changed.
Signed-off-by: NKONRAD Frederic <fred.konrad@greensocs.com>
Message-id: 1366708123-19626-3-git-send-email-fred.konrad@greensocs.com
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>

Create virtio-9p-device which extends virtio-device, so it can be connected on
virtio-bus.
Signed-off-by: NKONRAD Frederic <fred.konrad@greensocs.com>
Message-id: 1366708123-19626-2-git-send-email-fred.konrad@greensocs.com
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>

Signed-off-by: NOzan Çağlayan <ozancag@gmail.com>
Message-id: 1366711456-1935-1-git-send-email-ozancag@gmail.com
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>

This fixes build with gtk+-3.0.
Signed-off-by: NOzan Çağlayan <ozancag@gmail.com>
Message-id: 1366711402-1750-1-git-send-email-ozancag@gmail.com
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>

# By Gerd Hoffmann (3) and Hans de Goede (1)
# Via Gerd Hoffmann
* kraxel/usb.81:
  usb-host: raise libusbx minimum version to 1.0.13
  usb: better speed mismatch error reporting
  ehci_free_packet: Discard finished packets when the queue is halted
  xhci: remove XHCIRing->base (unused)

Message-id: 1366705929-11251-1-git-send-email-kraxel@redhat.com
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>

Allows to remove one FIXME.  Makes LIBUSB_LOG_LEVEL_WARNING build errors
go away.  And starting with that version libusb has a LIBUSBX_API_VERSION
define which allows to easily #ifdef version dependencies should that
need arrive in the future.
Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>

Report the supported speeds for device and port in the error message.
Also add the speeds to the tracepoint.  And while being at it drop
the redundant error message in usb_desc_attach, usb_device_attach will
report the error anyway.
Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>

With pipelining it is possible to encounter a finished packet when cleaning
the queue due to a halt. This happens when a non stall error happens while
talking to a real device. In this case the queue on the usb-host side will
continue processing packets, and we can have completed packets waiting in
the queue after an error condition packet causing a halt.

There are 2 reasons to discard the completed packets at this point, rather
then trying to writing them back to the guest:

1) The guest expect to be able to cancel and/or change packets after the
packet with the error without doing an unlink, so writing them back may
confuse the guest.

2) Since the queue does not advance when halted, the writing back of these
packets will fail anyways since p->qtdaddr != q->qtdaddr, so the
ehci_verify_qtd call in ehci_writeback_async_complete_packet will fail.

Note that 2) means that then only functional change this patch introduces
is the printing of a warning when this scenario happens.

Note that discarding these packets means that the guest driver and the device
will get out of sync! This is unfortunate, but should not be a problem since
with a non stall error (iow an io-error) the 2 are out of sync already anyways.
Still this patch adds a warning to signal this happening.

Note that sofar this has only been seen with a DVB-T receiver, which gives
of a MPEG-2 stream, which allows for recovering from lost packets, see:
https://bugzilla.redhat.com/show_bug.cgi?id=890320Signed-off-by: NHans de Goede <hdegoede@redhat.com>
Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>

Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>

filename was still uninitialised when it's used as a parameter to a
tracing function, so let's move the initialisation. Also, commit c2ad1b0c
forgot to add a NULL check, which this patch adds while we're at it.
Signed-off-by: NKevin Wolf <kwolf@redhat.com>
Reviewed-by: NEric Blake <eblake@redhat.com>
Tested-by: NAndreas Färber <afaerber@suse.de>
Message-id: 1366645720-11384-1-git-send-email-kwolf@redhat.com
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>