1. 07 3月, 2014 2 次提交
    • P
      configure: Always build with -fno-common · 4c288acb
      Peter Maydell 提交于
      MacOSX doesn't pull .o files from .a archives if the symbol that it
      requires is one which the .o file defines as a common symbol.
      (Common symbols are those declared without "extern"; the linker
      will merge together common symbols with the same name, so
      redeclaring the same variable in two compilation units results in
      them referring to the same symbol rather than a compilation error).
      
      This MacOSX difference from traditional linker behaviour means that
      "make check" produces link errors:
      
      Undefined symbols for architecture x86_64:
        "_cur_mon", referenced from:
            _error_vprintf in libqemuutil.a(qemu-error.o)
            _error_printf in libqemuutil.a(qemu-error.o)
            _error_printf_unless_qmp in libqemuutil.a(qemu-error.o)
            _error_print_loc in libqemuutil.a(qemu-error.o)
            _error_report in libqemuutil.a(qemu-error.o)
      ld: symbol(s) not found for architecture x86_64
      
      in this case because "cur_mon" is a common symbol in
      libqemustub.a(mon-set-error.o).
      
      In QEMU we don't make any use at all of the common symbol
      functionality, so we can avoid this problem entirely simply
      by compiling with -fno-common. Enable this option for all
      builds, not just MacOSX, so that if we ever inadvertently
      introduce multiple definitions of some variable that will
      be immediately spotted as a build error rather than only
      breaking the MacOSX build.
      Suggested-by: NMarkus Armbruster <armbru@redhat.com>
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      Reviewed-by: NRichard Henderson <rth@twiddle.net>
      Message-id: 1393451610-24617-1-git-send-email-peter.maydell@linaro.org
      4c288acb
    • P
      configure: Make C++ test work with --enable-werror · 9c83ffd8
      Peter Maydell 提交于
      gcc's C++ compiler complains about being passed some -W options
      which make sense for C but not for C++. This means we mustn't try
      a C++ compile with QEMU_CFLAGS, but only with a filtered version
      that removes the offending options. This filtering was already being
      done for uses of C++ in the build itself, but was omitted for the
      "does C++ work?" configure test. This only showed up when doing
      builds which explicitly enabled -Werror with --enable-werror,
      because the "do the compilers work" tests were mistakenly placed
      above the "default werror based on whether compiling from git" code.
      Another error in this category is that clang warns if you ask it to
      compile C++ code from a file named "foo.c". Further, because we
      were running do_cc in a subshell in the condition part of an "if",
      the error_exit inside do_compiler wouldn't terminate configure and
      we would plunge on regardless. Fix this complex of errors:
      
      1. Move the default-werror code up so that there are no invocations
      of compile_object and friends between it and the point where we
      set $werror explicitly based on the --enable-werror command line
      option.
      
      2. Provide a mechanism for filtering QEMU_CFLAGS to create
      QEMU_CXXFLAGS, and use it for the test we run here.
      
      3. Provide a do_cxx function to run a test with the C++ compiler
      rather than doing cute tricks with subshells and do_cc.
      
      4. Use a new temporary file TMPCXX for the C++ program fragment.
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      Message-id: 1393352869-22257-1-git-send-email-peter.maydell@linaro.org
      Tested-by: NAndreas Färber <afaerber@suse.de>
      9c83ffd8
  2. 05 3月, 2014 4 次提交
    • A
      block/gluster: Add missing argument to qemu_gluster_init() call · f55ea629
      Andreas Färber 提交于
      Commit adccfbcd (block: gluster - add
      reopen support.) did not supply the qemu_gluster_init() Error **
      argument, needed since commit a7451cb8
      (gluster: correctly propagate errors).
      
      Pass through qemu_gluster_reopen_prepare()'s errp, as done in
      qemu_gluster_open().
      
      Cc: Stefan Hajnoczi <stefanha@redhat.com>
      Signed-off-by: NAndreas Färber <afaerber@suse.de>
      Reviewed-by: NStefan Hajnoczi <stefanha@redhat.com>
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      f55ea629
    • P
      Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-03-04' into staging · ac458e12
      Peter Maydell 提交于
      trivial patches for 2014-03-04
      
      # gpg: Signature made Tue 04 Mar 2014 06:13:56 GMT using RSA key ID 74F0C838
      # gpg: Good signature from "Michael Tokarev <mjt@tls.msk.ru>"
      # gpg:                 aka "Michael Tokarev <mjt@corpit.ru>"
      # gpg:                 aka "Michael Tokarev <mjt@debian.org>"
      # gpg: WARNING: This key is not certified with a trusted signature!
      # gpg:          There is no indication that the signature belongs to the owner.
      # Primary key fingerprint: 6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044 65C5
      #      Subkey fingerprint: E190 8639 3B10 B51B AC2C  8B73 5253 C5AD 74F0 C838
      
      * remotes/mjt/tags/trivial-patches-2014-03-04:
        vl: Remove unneeded include file
        qga: Remove unneeded include file
        qemu-img: Remove unneeded include files
        exec: Remove unneeded include files
        util/iov: Use qemu/sockets.h instead of conditional code
        qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration
        tests/test-int128: Don't use __noclone__ attribute on clang
        stubs: Optimize dependencies for gdbstub.c
        tcg: Fix typo in comment (dependancies -> dependencies)
        bswap: Modify prototypes of st[wl]_{le, be}_p (avoid type conversions)
        bswap: Modify prototype of stb_p (avoid type conversions)
        object: Report type in error when not user creatable.
        include/qemu/host-utils.h: Trivial typo: ctz->cto
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      ac458e12
    • P
      Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging · e00ef747
      Peter Maydell 提交于
      * remotes/qmp-unstable/queue/qmp: (32 commits)
        qapi: Add missing null check to opts_start_struct()
        qapi: Clean up superfluous null check in qapi_dealloc_type_str()
        qapi: Clean up null checking in generated visitors
        qapi: Drop unused code in qapi-commands.py
        qapi: Drop nonsensical header guard in generated qapi-visit.c
        qapi: Fix licensing of scripts
        tests/qapi-schema: Cover flat union types
        tests/qapi-schema: Cover union types with base
        tests/qapi-schema: Cover complex types with base
        tests/qapi-schema: Cover anonymous union types
        tests/qapi-schema: Cover simple argument types
        tests/qapi-schema: Cover optional command arguments
        tests/qapi-schema: Actually check successful QMP command response
        monitor: Remove left-over code in do_info_profile.
        qerror: Improve QERR_DEVICE_NOT_ACTIVE message
        qmp: Check for returned data from __json_read in get_events
        dump: add 'query-dump-guest-memory-capability' command
        Define the architecture for compressed dump format
        dump: make kdump-compressed format available for 'dump-guest-memory'
        dump: add API to write dump pages
        ...
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      e00ef747
    • P
      Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging · 4a29420e
      Peter Maydell 提交于
      Block pull request
      
      # gpg: Signature made Fri 28 Feb 2014 18:27:24 GMT using RSA key ID 81AB73C8
      # gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>"
      # gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>"
      # gpg: WARNING: This key is not certified with a trusted signature!
      # gpg:          There is no indication that the signature belongs to the owner.
      # Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8
      
      * remotes/stefanha/tags/block-pull-request:
        block/vmdk: do not report file offset for compressed extents
        discard rbd error output when not relevant in qemu-iotests
        block: use /var/tmp instead of /tmp for -snapshot
        qemu-io-test: Disable Quorum test when not compiled in.
        qmp: Make Quorum error events more palatable.
        qmp: Fix BlockdevOptionQuorum.
        block: gluster - add reopen support.
        block: gluster - code movements, state storage changes
        qemu-iotests: add more tests to the "quick" group
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      4a29420e
  3. 04 3月, 2014 18 次提交
  4. 03 3月, 2014 6 次提交
  5. 02 3月, 2014 7 次提交
  6. 01 3月, 2014 3 次提交