1. 19 11月, 2015 3 次提交
  2. 13 11月, 2015 1 次提交
  3. 10 11月, 2015 21 次提交
  4. 04 11月, 2015 2 次提交
    • L
      migration: rename cancel to cleanup in SaveVMHandles · d1a8548c
      Liang Li 提交于
      'cleanup' seems more appropriate than 'cancel'.
      Signed-off-by: NLiang Li <liang.z.li@intel.com>
      Reviewed-by: Juan Quintela <quintela@redhat.com>al3
      Reviewed-by: Amit Shah <amit.shah@redhat.com>al3
      Signed-off-by: Juan Quintela <quintela@redhat.com>al3
      d1a8548c
    • L
      migration: rename qemu_savevm_state_cancel · ea7415fa
      Liang Li 提交于
      The function qemu_savevm_state_cancel is called after the migration
      in migration_thread, it seems strange to 'cancel' it after completion,
      rename it to qemu_savevm_state_cleanup looks better.
      Signed-off-by: NLiang Li <liang.z.li@intel.com>
      Reviewed-by: Juan Quintela <quintela@redhat.com>al3
      Reviewed-by: Amit Shah <amit.shah@redhat.com>al3
      Signed-off-by: Juan Quintela <quintela@redhat.com>al3
      ea7415fa
  5. 29 9月, 2015 2 次提交
  6. 11 9月, 2015 1 次提交
  7. 04 8月, 2015 1 次提交
  8. 15 7月, 2015 1 次提交
    • J
      migration: We also want to store the global state for savevm · 560d027b
      Juan Quintela 提交于
      Commit df4b1024 introduced global_state
      section.  But it only filled the state while doing migration.  While
      doing a savevm, we stored an empty string as state.  So when we did a
      loadvm, it complained that state was invalid.
      
      Fedora 21, 4.1.1, qemu 2.4.0-rc0
      > ../../configure --target-list="x86_64-softmmu"
      
      068 2s ... - output mismatch (see 068.out.bad)
      --- /home/bos/jhuston/src/qemu/tests/qemu-iotests/068.out	2015-07-08
      17:56:18.588164979 -0400
      +++ 068.out.bad	2015-07-09 17:39:58.636651317 -0400
      @@ -6,6 +6,8 @@
       QEMU X.Y.Z monitor - type 'help' for more information
       (qemu) savevm 0
       (qemu) quit
      +qemu-system-x86_64: Unknown savevm section or instance 'globalstate' 0
      +qemu-system-x86_64: Error -22 while loading VM state
       QEMU X.Y.Z monitor - type 'help' for more information
       (qemu) quit
       *** done
      Failures: 068
      Failed 1 of 1 tests
      
      Actually, there were two problems here:
      - we registered global_state too late for load_vm (fixed on another
        patch on the list)
      - we didn't store a valid state for savevm (fixed by this patch).
      Reported-by: NJohn Snow <jsnow@redhat.com>
      Signed-off-by: NJuan Quintela <quintela@redhat.com>
      Reviewed-by: NDr. David Alan Gilbert <dgilbert@redhat.com>
      Reviewed-by: NAmit Shah <amit.shah@redhat.com>
      Tested-by: NChristian Borntraeger <borntraeger@de.ibm.com>
      560d027b
  9. 07 7月, 2015 4 次提交
  10. 23 6月, 2015 3 次提交
  11. 12 6月, 2015 1 次提交
    • D
      Add a protective section footer · f68945d4
      Dr. David Alan Gilbert 提交于
      Badly formatted migration streams can go undetected or produce
      misleading errors due to a lock of checking at the end of sections.
      In particular a section that adds an extra 0x00 at the end
      causes what looks like a normal end of stream and thus doesn't produce
      any errors, and something that ends in a 0x01..0x04 kind of look
      like real section headers and then fail when the section parser tries
      to figure out which section they are.  This is made worse by the
      choice of 0x00..0x04 being small numbers that are particularly common
      in normal section data.
      
      This patch adds a section footer consisting of a marker (0x7e - ~)
      followed by the section-id that was also sent in the header.  If
      they mismatch then it throws an error explaining which section was
      being loaded.
      Signed-off-by: NDr. David Alan Gilbert <dgilbert@redhat.com>
      Reviewed-by: NJuan Quintela <quintela@redhat.com>
      Signed-off-by: NJuan Quintela <quintela@redhat.com>
      f68945d4