1. 13 5月, 2013 2 次提交
  2. 07 5月, 2013 1 次提交
    • L
      qga: set umask 0077 when daemonizing (CVE-2013-2007) · c689b4f1
      Laszlo Ersek 提交于
      The qemu guest agent creates a bunch of files with insecure permissions
      when started in daemon mode. For example:
      
        -rw-rw-rw- 1 root root /var/log/qemu-ga.log
        -rw-rw-rw- 1 root root /var/run/qga.state
        -rw-rw-rw- 1 root root /var/log/qga-fsfreeze-hook.log
      
      In addition, at least all files created with the "guest-file-open" QMP
      command, and all files created with shell output redirection (or
      otherwise) by utilities invoked by the fsfreeze hook script are affected.
      
      For now mask all file mode bits for "group" and "others" in
      become_daemon().
      
      Temporarily, for compatibility reasons, stick with the 0666 file-mode in
      case of files newly created by the "guest-file-open" QMP call. Do so
      without changing the umask temporarily.
      Signed-off-by: NLaszlo Ersek <lersek@redhat.com>
      Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>
      c689b4f1
  3. 22 3月, 2013 1 次提交
  4. 12 3月, 2013 6 次提交
  5. 29 1月, 2013 2 次提交
  6. 19 1月, 2013 1 次提交
  7. 09 1月, 2013 11 次提交
  8. 19 12月, 2012 2 次提交
  9. 05 10月, 2012 2 次提交
  10. 22 6月, 2012 2 次提交
  11. 30 5月, 2012 2 次提交
  12. 25 5月, 2012 1 次提交
  13. 15 5月, 2012 4 次提交
  14. 14 5月, 2012 1 次提交
    • J
      fix some common typos · a31f0531
      Jim Meyering 提交于
      These were identified using: http://github.com/lyda/misspell-check
      and run like this to create a bourne shell script using GNU sed's
      -i option:
      
      git ls-files|grep -vF .bin | misspellings -f - |grep -v '^ERROR:' |perl \
      -pe 's/^(.*?)\[(\d+)\]: (\w+) -> "(.*?)"$/sed -i '\''${2}s!$3!$4!'\'' $1/'
      
      Manually eliding the FP, "rela->real" and resolving "addres" to
      address (not "adders") we get this:
      
        sed -i '450s!thru!through!' Changelog
        sed -i '260s!neccessary!necessary!' coroutine-sigaltstack.c
        sed -i '54s!miniscule!minuscule!' disas.c
        sed -i '1094s!thru!through!' hw/usb/hcd-ehci.c
        sed -i '1095s!thru!through!' hw/usb/hcd-ehci.c
        sed -i '21s!unecessary!unnecessary!' qapi-schema-guest.json
        sed -i '307s!explictly!explicitly!' qemu-ga.c
        sed -i '490s!preceeding!preceding!' qga/commands-posix.c
        sed -i '792s!addres!address!' qga/commands-posix.c
        sed -i '6s!beeing!being!' tests/tcg/test-mmap.c
      
      Also, manually fix "arithmentic", spotted by Peter Maydell:
      
        sed -i 's!arithmentic!arithmetic!' coroutine-sigaltstack.c
      Signed-off-by: NJim Meyering <meyering@redhat.com>
      Reviewed-by: NPeter Maydell <peter.maydell@linaro.org>
      a31f0531
  15. 30 4月, 2012 2 次提交
    • M
      qemu-ga: add a whitelist for fsfreeze-safe commands · f22d85e9
      Michael Roth 提交于
      Currently we rely on fsfreeze/thaw commands disabling/enabling logging
      then having other commands check whether logging is disabled to avoid
      executing if they aren't safe for running while a filesystem is frozen.
      
      Instead, have an explicit whitelist of fsfreeze-safe commands, and
      consolidate logging and command enablement/disablement into a pair
      of helper functions: ga_set_frozen()/ga_unset_frozen()
      Signed-off-by: NMichael Roth <mdroth@linux.vnet.ibm.com>
      f22d85e9
    • M
      qemu-ga: improve recovery options for fsfreeze · 9e8aded4
      Michael Roth 提交于
      guest-fsfreeze-thaw relies on state information obtained from
      guest-fsfreeze-freeze to determine what filesystems to unfreeze.
      This is unreliable due to the fact that that state does not account
      for FIFREEZE being issued by other processes, or previous instances
      of qemu-ga. This means in certain situations we cannot thaw
      filesystems even with a responsive qemu-ga instance at our disposal.
      
      This patch allows guest-fsfreeze-thaw to be issued unconditionally.
      It also adds some additional logic to allow us to thaw filesystems
      regardless of how many times the filesystem's "frozen" refcount has
      been incremented by any guest processes.
      
      Also, guest-fsfreeze-freeze now operates atomically: on success all
      freezable filesystems are frozen, and on error all filesystems are
      thawed. The ambiguous "GUEST_FSFREEZE_STATUS_ERROR" state is no
      longer entered.
      Signed-off-by: NMichael Roth <mdroth@linux.vnet.ibm.com>
      9e8aded4