1. 16 8月, 2016 10 次提交
    • T
      slirp: Rename "struct arphdr" to "struct slirp_arphdr" · 1f8b56e7
      Thomas Huth 提交于
      struct arphdr is already used by the system headers on OpenBSD
      and thus QEMU does not compile here anymore. Fix it by renaming
      our struct to slirp_arphdr instead.
      
      Reported-by: Brad Smith
      Reviewed-by: NSamuel Thibault <samuel.thibault@ens-lyon.org>
      Signed-off-by: NThomas Huth <thuth@redhat.com>
      Message-id: 1471249494-17392-1-git-send-email-thuth@redhat.com
      Buglink: https://bugs.launchpad.net/qemu/+bug/1613133Signed-off-by: NThomas Huth <thuth@redhat.com>
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      1f8b56e7
    • M
      char: fix waiting for TLS and telnet connection · 1dc8a669
      Marc-André Lureau 提交于
      Since commit d7a04fd7, tcp_chr_wait_connected() was introduced,
      so vhost-user could wait until a backend started successfully. In
      vhost-user case, the chr socket must be plain unix, and the chr+vhost
      setup happens synchronously during qemu startup.
      
      However, with TLS and telnet socket, initial socket setup happens
      asynchronously, and s->connected is not set after the socket is
      accepted. In order for tcp_chr_wait_connected() to not keep accepting
      new connections and proceed with the last accepted socket, it can
      check for s->ioc instead.
      Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com>
      Reviewed-by: NDaniel P. Berrange <berrange@redhat.com>
      Message-id: 20160816083332.15088-1-marcandre.lureau@redhat.com
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      1dc8a669
    • D
      virtio-gpu: fix missing log.h include file · 8afc224f
      Daniel P. Berrange 提交于
      The virtio-gpu.h file defines a macro VIRTIO_GPU_FILL_CMD
      which includes a call to qemu_log_mask, but does not
      include qemu/log.h. In a default configure, it is lucky
      and gets qemu/log.h indirectly due to the 'log' trace
      backend being enabled. If that trace backend is disabled
      though, eg
      
       ./configure --enable-trace-backends=nop
      
      Then the build will fail:
      
      In file included from /home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c:19:0:
      /home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c: In function ‘virgl_cmd_create_resource_2d’:
      /home/berrange/src/virt/qemu/include/hw/virtio/virtio-gpu.h:138:13: error: implicit declaration of function ‘qemu_log_mask’ [-Werror=implicit-function-declaration]
                   qemu_log_mask(LOG_GUEST_ERROR,                              \
                   ^
      /home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c:34:5: note: in expansion of macro ‘VIRTIO_GPU_FILL_CMD’
           VIRTIO_GPU_FILL_CMD(c2d);
           ^~~~~~~~~~~~~~~~~~~
      /home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c:34:5: error: nested extern declaration of ‘qemu_log_mask’ [-Werror=nested-externs]
      In file included from /home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c:19:0:
      /home/berrange/src/virt/qemu/include/hw/virtio/virtio-gpu.h:138:27: error: ‘LOG_GUEST_ERROR’ undeclared (first use in this function)
                   qemu_log_mask(LOG_GUEST_ERROR,                              \
      
      [snip many more errors]
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      Message-id: 1470648700-3474-1-git-send-email-berrange@redhat.com
      Reviewed-by: NPeter Maydell <peter.maydell@linaro.org>
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      8afc224f
    • P
      Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160816' into staging · 2d1c8d54
      Peter Maydell 提交于
      Build fix for the ccw bios (bios itself not rebuilt).
      
      # gpg: Signature made Tue 16 Aug 2016 08:00:16 BST
      # gpg:                using RSA key 0xDECF6B93C6F02FAF
      # gpg: Good signature from "Cornelia Huck <huckc@linux.vnet.ibm.com>"
      # gpg:                 aka "Cornelia Huck <cornelia.huck@de.ibm.com>"
      # Primary key fingerprint: C3D0 D66D C362 4FF6 A8C0  18CE DECF 6B93 C6F0 2FAF
      
      * remotes/cohuck/tags/s390x-20160816:
        pc-bios/s390-ccw.img: Fix build
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      2d1c8d54
    • P
      Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging · 66940d74
      Peter Maydell 提交于
      Block layer patches for 2.7.0-rc3
      
      # gpg: Signature made Mon 15 Aug 2016 14:55:46 BST
      # gpg:                using RSA key 0x7F09B272C88F2FD6
      # gpg: Good signature from "Kevin Wolf <kwolf@redhat.com>"
      # Primary key fingerprint: DC3D EB15 9A9A F95D 3D74  56FE 7F09 B272 C88F 2FD6
      
      * remotes/kevin/tags/for-upstream:
        iotests: Test case for wrong runtime option types
        block/nbd: Store runtime option values
        block/blkdebug: Store config filename
        block/nbd: Use QemuOpts for runtime options
        block/ssh: Use QemuOpts for runtime options
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      66940d74
    • C
      pc-bios/s390-ccw.img: Fix build · c86c03cf
      Christian Borntraeger 提交于
      Since
      commit a9c87304 ("build-sys: fix building with make CFLAGS=.. argument")
      
      pc-bios/s390-ccw.img build might fail with
      
      --- snip ---
      main.o: In function `virtio_setup':
      qemu/pc-bios/s390-ccw/main.c:117: undefined reference to `__stack_chk_fail'
      --- snip ---
      
      Changing the CFLAGS to QEMU_CFLAGS does the trick. We also need to
      add -fno-strict-aliasing as this was filtered out.
      Signed-off-by: NChristian Borntraeger <borntraeger@de.ibm.com>
      Message-Id: <1471258997-5811-1-git-send-email-borntraeger@de.ibm.com>
      Signed-off-by: NCornelia Huck <cornelia.huck@de.ibm.com>
      c86c03cf
    • P
      Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160815' into staging · f3b9e787
      Peter Maydell 提交于
      ppc patch queue for 2016-08-15
      
      Just a single patch here, I hope this is the last ppc / spapr fix to
      squeeze into qemu-2.7.
      
      # gpg: Signature made Mon 15 Aug 2016 07:46:36 BST
      # gpg:                using RSA key 0x6C38CACA20D9B392
      # gpg: Good signature from "David Gibson <david@gibson.dropbear.id.au>"
      # gpg:                 aka "David Gibson (Red Hat) <dgibson@redhat.com>"
      # gpg:                 aka "David Gibson (ozlabs.org) <dgibson@ozlabs.org>"
      # gpg: WARNING: This key is not certified with sufficiently trusted signatures!
      # gpg:          It is not certain that the signature belongs to the owner.
      # Primary key fingerprint: 75F4 6586 AE61 A66C C44E  87DC 6C38 CACA 20D9 B392
      
      * remotes/dgibson/tags/ppc-for-2.7-20160815:
        ppc: parse cpu features once
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      f3b9e787
    • P
      Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20160812-tag-2' into staging · e5bfef86
      Peter Maydell 提交于
      Xen 2016/08/12, fixed commit message
      
      # gpg: Signature made Sat 13 Aug 2016 00:39:09 BST
      # gpg:                using RSA key 0x894F8F4870E1AE90
      # gpg: Good signature from "Stefano Stabellini <stefano.stabellini@eu.citrix.com>"
      # Primary key fingerprint: D04E 33AB A51F 67BA 07D3  0AEA 894F 8F48 70E1 AE90
      
      * remotes/sstabellini/tags/xen-20160812-tag-2:
        xen: handle inbound migration of VMs without ioreq server pages
        Xen: fix converity warning of xen_pt_config_init()
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      e5bfef86
    • P
      Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging · aba5d976
      Peter Maydell 提交于
      # gpg: Signature made Fri 12 Aug 2016 11:48:03 BST
      # gpg:                using RSA key 0x9CA4ABB381AB73C8
      # gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>"
      # gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>"
      # Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8
      
      * remotes/stefanha/tags/tracing-pull-request:
        trace-events: fix first line comment in trace-events
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      aba5d976
    • P
      pc-bios/optionrom: Fix OpenBSD build with better detection of linker emulation · e57218b6
      Peter Maydell 提交于
      The various host OSes are irritatingly variable about the name
      of the linker emulation we need to pass to ld's -m option to
      build the i386 option ROMs. Instead of doing this via a
      CONFIG ifdef, check in configure whether any of the emulation
      names we know about will work and pass the right answer through
      to the makefile. If we can't find one, we fall back to not trying
      to build the option ROMs, in the same way we would for a non-x86
      host platform.
      
      This is in particular necessary to unbreak the build on OpenBSD,
      since it wants a different answer to FreeBSD and we don't have
      an existing CONFIG_ variable that distinguishes the two.
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      Reviewed-by: NSean Bruno <sbruno@freebsd.org>
      Message-id: 1470672688-6754-1-git-send-email-peter.maydell@linaro.org
      e57218b6
  2. 15 8月, 2016 7 次提交
  3. 13 8月, 2016 3 次提交
  4. 12 8月, 2016 3 次提交
    • P
      target-arm: Fix warn about implicit conversion · 6bbbb0ac
      Pranith Kumar 提交于
      Clang warns about an implicit conversion as follows:
      
      /mnt/devops/code/qemu/target-arm/neon_helper.c:1075:1: warning: implicit conversion from 'int' to 'int8_t' (aka 'signed char') changes value from 128 to -128 [-Wconstant-conversion]
      NEON_VOP_ENV(qrshl_s8, neon_s8, 4)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      /mnt/devops/code/qemu/target-arm/neon_helper.c:116:83: note: expanded from macro 'NEON_VOP_ENV'
      uint32_t HELPER(glue(neon_,name))(CPUARMState *env, uint32_t arg1, uint32_t arg2) \
                                                                                        ^
      /mnt/devops/code/qemu/target-arm/neon_helper.c:106:5: note: expanded from macro '\
      NEON_VOP_BODY'
          NEON_DO##n; \
          ^~~~~~~~~~
      <scratch space>:21:1: note: expanded from here
      NEON_DO4
      ^~~~~~~~
      /mnt/devops/code/qemu/target-arm/neon_helper.c:93:5: note: expanded from macro 'NEON_DO4'
          NEON_FN(vdest.v1, vsrc1.v1, vsrc2.v1); \
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      /mnt/devops/code/qemu/target-arm/neon_helper.c:1054:23: note: expanded from macro 'NEON_FN'
                  dest = (1 << (sizeof(src1) * 8 - 1)); \
                       ~  ~~^~~~~~~~~~~~~~~~~~~~~~~~~
      
      Fix it by casting to appropriate type.
      Signed-off-by: NPranith Kumar <bobby.prani@gmail.com>
      Reviewed-by: NPeter Maydell <peter.maydell@linaro.org>
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      6bbbb0ac
    • L
      trace-events: fix first line comment in trace-events · e723b871
      Laurent Vivier 提交于
      Documentation is docs/tracing.txt instead of docs/trace-events.txt.
      
      find . -name trace-events -exec \
           sed -i "s?See docs/trace-events.txt for syntax documentation.?See docs/tracing.txt for syntax documentation.?" \
           {} \;
      Signed-off-by: NLaurent Vivier <lvivier@redhat.com>
      Message-id: 1470669081-17860-1-git-send-email-lvivier@redhat.com
      Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      e723b871
    • P
      Merge remote-tracking branch 'remotes/amit-migration/tags/migration-for-2.7-7' into staging · 28b87442
      Peter Maydell 提交于
      Migration:
       - couple of bug fixes
       - couple of typo fixes
      
      # gpg: Signature made Thu 11 Aug 2016 12:36:00 BST
      # gpg:                using RSA key 0xEB0B4DFC657EF670
      # gpg: Good signature from "Amit Shah <amit@amitshah.net>"
      # gpg:                 aka "Amit Shah <amit@kernel.org>"
      # gpg:                 aka "Amit Shah <amitshah@gmx.net>"
      # Primary key fingerprint: 48CA 3722 5FE7 F4A8 B337  2735 1E9A 3B5F 8540 83B6
      #      Subkey fingerprint: CC63 D332 AB8F 4617 4529  6534 EB0B 4DFC 657E F670
      
      * remotes/amit-migration/tags/migration-for-2.7-7:
        migration/socket: fix typo in file header
        migration: fix live migration failure with compression
        migration: mmap error check fix
        migration/ram: fix typo
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      28b87442
  5. 11 8月, 2016 10 次提交
    • P
      Update ancient copyright string in -version output · d915b7bb
      Peter Maydell 提交于
      Currently the -version command line argument prints a string ending
      with "Copyright (c) 2003-2008 Fabrice Bellard".  This is now some
      eight years out of date; abstract it out of the several places that
      print the string and update it to:
      
      Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project developers
      
      to reflect the work by all the QEMU Project contributors over the
      last decade.
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      Acked-by: NStefan Hajnoczi <stefanha@redhat.com>
      Reviewed-by: NEric Blake <eblake@redhat.com>
      Message-id: 1470309276-5012-1-git-send-email-peter.maydell@linaro.org
      d915b7bb
    • P
      Merge remote-tracking branch 'remotes/amit/tags/vser-for-2.7-1' into staging · bea048dc
      Peter Maydell 提交于
      virtio-console: fix receiving data from guest
      
      # gpg: Signature made Thu 11 Aug 2016 12:17:55 BST
      # gpg:                using RSA key 0xEB0B4DFC657EF670
      # gpg: Good signature from "Amit Shah <amit@amitshah.net>"
      # gpg:                 aka "Amit Shah <amit@kernel.org>"
      # gpg:                 aka "Amit Shah <amitshah@gmx.net>"
      # Primary key fingerprint: 48CA 3722 5FE7 F4A8 B337  2735 1E9A 3B5F 8540 83B6
      #      Subkey fingerprint: CC63 D332 AB8F 4617 4529  6534 EB0B 4DFC 657E F670
      
      * remotes/amit/tags/vser-for-2.7-1:
        virtio-console: set frontend open permanently for console devs
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      bea048dc
    • C
      migration/socket: fix typo in file header · 474c624d
      Cao jin 提交于
      Code of inet socket & unix socket is merged together.
      Also add some newlines, make code block well separated.
      
      Cc: Daniel P. Berrange <berrange@redhat.com>
      Cc: Juan Quintela <quintela@redhat.com>
      Cc: Amit Shah <amit.shah@redhat.com>
      Reviewed-by: NDaniel P. Berrange <berrange@redhat.com>
      Signed-off-by: NCao jin <caoj.fnst@cn.fujitsu.com>
      Message-Id: <1469696074-12744-4-git-send-email-caoj.fnst@cn.fujitsu.com>
      Signed-off-by: NAmit Shah <amit.shah@redhat.com>
      474c624d
    • L
      migration: fix live migration failure with compression · 787d134f
      Liang Li 提交于
      Because of commit 11808bb0, which remove some condition checks
      of 'f->ops->writev_buffer', 'qemu_put_qemu_file' should be enhanced
      to clear the 'f_src->iovcnt', or 'f_src->iovcnt' may exceed the
      MAX_IOV_SIZE which will break live migration. This should be fixed.
      Signed-off-by: NLiang Li <liang.z.li@intel.com>
      Reported-by: NJinshi Zhang <jinshi.c.zhang@intel.com>
      Reviewed-by: NDr. David Alan Gilbert <dgilbert@redhat.com>
      Message-Id: <1470702146-24399-1-git-send-email-liang.z.li@intel.com>
      Signed-off-by: NAmit Shah <amit.shah@redhat.com>
      787d134f
    • E
      migration: mmap error check fix · 0e8b3cdf
      Evgeny Yakovlev 提交于
      mmap man page:
      "On success, mmap() returns a pointer to the mapped area. On error, the
      value MAP_FAILED (that is, (void *) -1) is returned, and errno  is  set
      to indicate the cause of the error."
      
      The check in postcopy_get_tmp_page is definitely wrong and should be
      fixed.
      Signed-off-by: NEvgeny Yakovlev <eyakovlev@virtuozzo.com>
      Signed-off-by: NDenis V. Lunev <den@openvz.org>
      Reviewed-by: NAmit Shah <amit.shah@redhat.com>
      Reviewed-by: NDr. David Alan Gilbert <dgilbert@redhat.com>
      CC: Juan Quintela <quintela@redhat.com>
      CC: Amit Shah <amit.shah@redhat.com>
      Message-Id: <1469785705-16670-1-git-send-email-den@openvz.org>
      Signed-off-by: NAmit Shah <amit.shah@redhat.com>
      0e8b3cdf
    • C
      migration/ram: fix typo · e110aa91
      Cao jin 提交于
      Signed-off-by: NCao jin <caoj.fnst@cn.fujitsu.com>
      Message-Id: <1469776231-23820-1-git-send-email-caoj.fnst@cn.fujitsu.com>
      Signed-off-by: NAmit Shah <amit.shah@redhat.com>
      e110aa91
    • D
      virtio-console: set frontend open permanently for console devs · bce6261e
      Daniel P. Berrange 提交于
      The virtio-console.c file handles both serial consoles
      and interactive consoles, since they're backed by the
      same device model.
      
      Since serial devices are expected to be reliable and
      need to notify the guest when the backend is opened
      or closed, the virtio-console.c file wires up support
      for chardev events. This affects both serial consoles
      and interactive consoles, using a network connection
      based chardev backend such as 'socket', but not when
      using a PTY based backend or plain 'file' backends.
      
      When the host side is not connected the handle_output()
      method in virtio-serial-bus.c will drop any data sent
      by the guest, before it even reaches the virtio-console.c
      code. This means that if the chardev has a logfile
      configured, the data will never get logged.
      
      Consider for example, configuring a x86_64 guest with a
      plain UART serial port
      
        -chardev socket,id=charserial1,host=127.0.0.1,port=9001,server,nowait,logfile=console1.log,logappend=on
        -device isa-serial,chardev=charserial1,id=serial1
      
      vs a s390 guest which has to use the virtio-console port
      
        -chardev socket,id=charconsole1,host=127.0.0.1,port=9000,server,nowait,logfile=console2.log,logappend=on
        -device virtconsole,chardev=charconsole1,id=console1
      
      The isa-serial one gets data written to the log regardless
      of whether a client is connected, while the virtioconsole
      one only gets data written to the log when a client is
      connected.
      
      There is no need for virtio-serial-bus.c to aggressively
      drop the data for console devices, as the chardev code is
      prefectly capable of discarding the data itself.
      
      So this patch changes virtconsole devices so that they
      are always marked as having the host side open. This
      ensures that the guest OS will always send any data it
      has (Linux virtio-console hvc driver actually ignores
      the host open state and sends data regardless, but we
      should not rely on that), and also prevents the
      virtio-serial-bus code prematurely discarding data.
      
      The behaviour of virtserialport devices is *not* changed,
      only virtconsole, because for the former, it is important
      that the guest OSknow exactly when the host side is opened
      / closed so it can do any protocol re-negotiation that may
      be required.
      
      Fixes bug: https://bugs.launchpad.net/qemu/+bug/1599214Acked-by: NCornelia Huck <cornelia.huck@de.ibm.com>
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      Message-Id: <1470241360-3574-2-git-send-email-berrange@redhat.com>
      Signed-off-by: NAmit Shah <amit.shah@redhat.com>
      bce6261e
    • P
      Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging · 144a6db0
      Peter Maydell 提交于
      # gpg: Signature made Thu 11 Aug 2016 11:35:33 BST
      # gpg:                using RSA key 0x9CA4ABB381AB73C8
      # gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>"
      # gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>"
      # Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8
      
      * remotes/stefanha/tags/block-pull-request:
        linux-aio: Handle io_submit() failure gracefully
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      144a6db0
    • K
      linux-aio: Handle io_submit() failure gracefully · 44713c9e
      Kevin Wolf 提交于
      It is generally not expected that io_submit() fails other than with
      -EAGAIN, but corner cases like SELinux refusing I/O when permissions are
      revoked are still possible. In this case, we shouldn't abort, but just
      return an I/O error for the request.
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      Message-id: 1470741619-23231-1-git-send-email-kwolf@redhat.com
      Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      44713c9e
    • P
      Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging · d08306dc
      Peter Maydell 提交于
      virtio/vhost: fixes
      
      some bugfixes for virtio/vhost
      Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
      
      # gpg: Signature made Wed 10 Aug 2016 16:16:22 BST
      # gpg:                using RSA key 0x281F0DB8D28D5469
      # gpg: Good signature from "Michael S. Tsirkin <mst@kernel.org>"
      # gpg:                 aka "Michael S. Tsirkin <mst@redhat.com>"
      # Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
      #      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469
      
      * remotes/mst/tags/for_upstream:
        vhost-user: Attempt to fix a race with set_mem_table.
        vhost-user: Introduce a new protocol feature REPLY_ACK.
        vhost: check for vhost_ops before using.
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      d08306dc
  6. 10 8月, 2016 7 次提交
    • P
      Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging · 4b3e5c06
      Peter Maydell 提交于
      * pc-bios/optionrom/Makefile fixes
      * warning fixes for __atomic_load and -1 << x in clang
      * missed interrupt fix from Gonglei
      * checkpatch fix from Radim and myself
      
      # gpg: Signature made Wed 10 Aug 2016 14:54:31 BST
      # gpg:                using RSA key 0xBFFBD25F78C7AE83
      # gpg: Good signature from "Paolo Bonzini <bonzini@gnu.org>"
      # gpg:                 aka "Paolo Bonzini <pbonzini@redhat.com>"
      # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
      #      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83
      
      * remotes/bonzini/tags/for-upstream:
        checkpatch: default to success if only warnings
        checkpatch: bump most warnings to errors
        CODING_STYLE, checkpatch: update line length rules
        checkpatch: check for CVS keywords on all sources
        checkpatch: tweak the files in which TABs are checked
        timer: set vm_clock disabled default
        checkpatch: ignore automatically imported Linux headers
        clang: Fix warning reg. expansion to 'defined'
        Disable warn about left shifts of negative values
        atomic: strip "const" from variables declared with typeof
        optionrom: fix compilation with mingw docker target
        optionrom: add -fno-stack-protector
        build-sys: fix building with make CFLAGS=.. argument
        linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      4b3e5c06
    • P
      vhost-user: Attempt to fix a race with set_mem_table. · 28ed5ef1
      Prerna Saxena 提交于
      The set_mem_table command currently does not seek a reply. Hence, there is
      no easy way for a remote application to notify to QEMU when it finished
      setting up memory, or if there were errors doing so.
      
      As an example:
      (1) Qemu sends a SET_MEM_TABLE to the backend (eg, a vhost-user net
      application). SET_MEM_TABLE does not require a reply according to the spec.
      (2) Qemu commits the memory to the guest.
      (3) Guest issues an I/O operation over a new memory region which was configured on (1).
      (4) The application has not yet remapped the memory, but it sees the I/O request.
      (5) The application cannot satisfy the request because it does not know about those GPAs.
      
      While a guaranteed fix would require a protocol extension (committed separately),
      a best-effort workaround for existing applications is to send a GET_FEATURES
      message before completing the vhost_user_set_mem_table() call.
      Since GET_FEATURES requires a reply, an application that processes vhost-user
      messages synchronously would probably have completed the SET_MEM_TABLE before replying.
      Signed-off-by: NPrerna Saxena <prerna.saxena@nutanix.com>
      Reviewed-by: NMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
      28ed5ef1
    • P
      vhost-user: Introduce a new protocol feature REPLY_ACK. · ca525ce5
      Prerna Saxena 提交于
      This introduces the VHOST_USER_PROTOCOL_F_REPLY_ACK.
      
      If negotiated, client applications should send a u64 payload in
      response to any message that contains the "need_reply" bit set
      on the message flags. Setting the payload to "zero" indicates the
      command finished successfully. Likewise, setting it to "non-zero"
      indicates an error.
      
      Currently implemented only for SET_MEM_TABLE.
      Reviewed-by: NMarc-André Lureau <marcandre.lureau@redhat.com>
      Signed-off-by: NPrerna Saxena <prerna.saxena@nutanix.com>
      Reviewed-by: NMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
      ca525ce5
    • I
      vhost: check for vhost_ops before using. · ca10203c
      Ilya Maximets 提交于
      'vhost_set_vring_enable()' tries to call function using pointer to
      'vhost_ops' which can be already zeroized in 'vhost_dev_cleanup()'
      while vhost disconnection.
      
      Fix that by checking 'vhost_ops' before using. This fixes QEMU crash
      on calling 'ethtool -L eth0 combined 2' if vhost disconnected.
      Signed-off-by: NIlya Maximets <i.maximets@samsung.com>
      Reviewed-by: NMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
      ca10203c
    • P
      Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160810' into staging · d578cca3
      Peter Maydell 提交于
      ppc patch queue for 2016-08-10
      
      Here are some more last minute PAPR and ppc related fixes for
      qemu-2.7.  One patch makes compressed memory dumps work with guest
      kernels using page sizes up to 64KiB.  This is important since most
      current pseries guests use a 64KiB default page size.  The remainder
      fix a regression with handling of CPU aliases which causes serious
      problem for libvirt.
      
      # gpg: Signature made Wed 10 Aug 2016 06:44:27 BST
      # gpg:                using RSA key 0x6C38CACA20D9B392
      # gpg: Good signature from "David Gibson <david@gibson.dropbear.id.au>"
      # gpg:                 aka "David Gibson (Red Hat) <dgibson@redhat.com>"
      # gpg:                 aka "David Gibson (ozlabs.org) <dgibson@ozlabs.org>"
      # gpg: WARNING: This key is not certified with sufficiently trusted signatures!
      # gpg:          It is not certain that the signature belongs to the owner.
      # Primary key fingerprint: 75F4 6586 AE61 A66C C44E  87DC 6C38 CACA 20D9 B392
      
      * remotes/dgibson/tags/ppc-for-2.7-20160810:
        ppc/kvm: Register also a generic spapr CPU core family type
        ppc/kvm: Do not mess up the generic CPU family registration
        hw/ppc/spapr: Look up CPU alias names instead of hard-coding the aliases
        ppc: Introduce a function to look up CPU alias strings
        spapr: remove extra type variable
        ppc64: fix compressed dump with pseries kernel
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      d578cca3
    • P
      checkpatch: default to success if only warnings · 141de886
      Paolo Bonzini 提交于
      CHK-level checks have been removed from checkpatch or bumped to
      errors, so there is no effect anymore for --strict/--subjective.
      Furthermore, even most WARNs have been bumped to errors, with
      WARN only reserved to things that patchew probably ought not
      to complain about (and that maintainers probably will notice
      anyway during review if they are extreme).
      
      Default to exiting with success even if there are WARN-level
      failures, and cause --strict to fail for warnings.  Maintainers
      that want to have a strict 80-character limit for their subsystem
      can add it to a commit hook for example.
      
      The --subjective synonym is removed.
      Reviewed-by: NMarkus Armbruster <armbru@redhat.com>
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      141de886
    • P
      checkpatch: bump most warnings to errors · c2df8783
      Paolo Bonzini 提交于
      This only leaves a warning-level message for the extra-long lines
      soft limit.  Everything else is bumped up.
      
      In the future warnings can be added for checks that can have false
      positives.
      Reviewed-by: NMarkus Armbruster <armbru@redhat.com>
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      c2df8783