1. 16 8月, 2016 13 次提交
  2. 15 8月, 2016 7 次提交
  3. 13 8月, 2016 3 次提交
  4. 12 8月, 2016 3 次提交
    • P
      target-arm: Fix warn about implicit conversion · 6bbbb0ac
      Pranith Kumar 提交于
      Clang warns about an implicit conversion as follows:
      
      /mnt/devops/code/qemu/target-arm/neon_helper.c:1075:1: warning: implicit conversion from 'int' to 'int8_t' (aka 'signed char') changes value from 128 to -128 [-Wconstant-conversion]
      NEON_VOP_ENV(qrshl_s8, neon_s8, 4)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      /mnt/devops/code/qemu/target-arm/neon_helper.c:116:83: note: expanded from macro 'NEON_VOP_ENV'
      uint32_t HELPER(glue(neon_,name))(CPUARMState *env, uint32_t arg1, uint32_t arg2) \
                                                                                        ^
      /mnt/devops/code/qemu/target-arm/neon_helper.c:106:5: note: expanded from macro '\
      NEON_VOP_BODY'
          NEON_DO##n; \
          ^~~~~~~~~~
      <scratch space>:21:1: note: expanded from here
      NEON_DO4
      ^~~~~~~~
      /mnt/devops/code/qemu/target-arm/neon_helper.c:93:5: note: expanded from macro 'NEON_DO4'
          NEON_FN(vdest.v1, vsrc1.v1, vsrc2.v1); \
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      /mnt/devops/code/qemu/target-arm/neon_helper.c:1054:23: note: expanded from macro 'NEON_FN'
                  dest = (1 << (sizeof(src1) * 8 - 1)); \
                       ~  ~~^~~~~~~~~~~~~~~~~~~~~~~~~
      
      Fix it by casting to appropriate type.
      Signed-off-by: NPranith Kumar <bobby.prani@gmail.com>
      Reviewed-by: NPeter Maydell <peter.maydell@linaro.org>
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      6bbbb0ac
    • L
      trace-events: fix first line comment in trace-events · e723b871
      Laurent Vivier 提交于
      Documentation is docs/tracing.txt instead of docs/trace-events.txt.
      
      find . -name trace-events -exec \
           sed -i "s?See docs/trace-events.txt for syntax documentation.?See docs/tracing.txt for syntax documentation.?" \
           {} \;
      Signed-off-by: NLaurent Vivier <lvivier@redhat.com>
      Message-id: 1470669081-17860-1-git-send-email-lvivier@redhat.com
      Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      e723b871
    • P
      Merge remote-tracking branch 'remotes/amit-migration/tags/migration-for-2.7-7' into staging · 28b87442
      Peter Maydell 提交于
      Migration:
       - couple of bug fixes
       - couple of typo fixes
      
      # gpg: Signature made Thu 11 Aug 2016 12:36:00 BST
      # gpg:                using RSA key 0xEB0B4DFC657EF670
      # gpg: Good signature from "Amit Shah <amit@amitshah.net>"
      # gpg:                 aka "Amit Shah <amit@kernel.org>"
      # gpg:                 aka "Amit Shah <amitshah@gmx.net>"
      # Primary key fingerprint: 48CA 3722 5FE7 F4A8 B337  2735 1E9A 3B5F 8540 83B6
      #      Subkey fingerprint: CC63 D332 AB8F 4617 4529  6534 EB0B 4DFC 657E F670
      
      * remotes/amit-migration/tags/migration-for-2.7-7:
        migration/socket: fix typo in file header
        migration: fix live migration failure with compression
        migration: mmap error check fix
        migration/ram: fix typo
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      28b87442
  5. 11 8月, 2016 10 次提交
    • P
      Update ancient copyright string in -version output · d915b7bb
      Peter Maydell 提交于
      Currently the -version command line argument prints a string ending
      with "Copyright (c) 2003-2008 Fabrice Bellard".  This is now some
      eight years out of date; abstract it out of the several places that
      print the string and update it to:
      
      Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project developers
      
      to reflect the work by all the QEMU Project contributors over the
      last decade.
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      Acked-by: NStefan Hajnoczi <stefanha@redhat.com>
      Reviewed-by: NEric Blake <eblake@redhat.com>
      Message-id: 1470309276-5012-1-git-send-email-peter.maydell@linaro.org
      d915b7bb
    • P
      Merge remote-tracking branch 'remotes/amit/tags/vser-for-2.7-1' into staging · bea048dc
      Peter Maydell 提交于
      virtio-console: fix receiving data from guest
      
      # gpg: Signature made Thu 11 Aug 2016 12:17:55 BST
      # gpg:                using RSA key 0xEB0B4DFC657EF670
      # gpg: Good signature from "Amit Shah <amit@amitshah.net>"
      # gpg:                 aka "Amit Shah <amit@kernel.org>"
      # gpg:                 aka "Amit Shah <amitshah@gmx.net>"
      # Primary key fingerprint: 48CA 3722 5FE7 F4A8 B337  2735 1E9A 3B5F 8540 83B6
      #      Subkey fingerprint: CC63 D332 AB8F 4617 4529  6534 EB0B 4DFC 657E F670
      
      * remotes/amit/tags/vser-for-2.7-1:
        virtio-console: set frontend open permanently for console devs
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      bea048dc
    • C
      migration/socket: fix typo in file header · 474c624d
      Cao jin 提交于
      Code of inet socket & unix socket is merged together.
      Also add some newlines, make code block well separated.
      
      Cc: Daniel P. Berrange <berrange@redhat.com>
      Cc: Juan Quintela <quintela@redhat.com>
      Cc: Amit Shah <amit.shah@redhat.com>
      Reviewed-by: NDaniel P. Berrange <berrange@redhat.com>
      Signed-off-by: NCao jin <caoj.fnst@cn.fujitsu.com>
      Message-Id: <1469696074-12744-4-git-send-email-caoj.fnst@cn.fujitsu.com>
      Signed-off-by: NAmit Shah <amit.shah@redhat.com>
      474c624d
    • L
      migration: fix live migration failure with compression · 787d134f
      Liang Li 提交于
      Because of commit 11808bb0, which remove some condition checks
      of 'f->ops->writev_buffer', 'qemu_put_qemu_file' should be enhanced
      to clear the 'f_src->iovcnt', or 'f_src->iovcnt' may exceed the
      MAX_IOV_SIZE which will break live migration. This should be fixed.
      Signed-off-by: NLiang Li <liang.z.li@intel.com>
      Reported-by: NJinshi Zhang <jinshi.c.zhang@intel.com>
      Reviewed-by: NDr. David Alan Gilbert <dgilbert@redhat.com>
      Message-Id: <1470702146-24399-1-git-send-email-liang.z.li@intel.com>
      Signed-off-by: NAmit Shah <amit.shah@redhat.com>
      787d134f
    • E
      migration: mmap error check fix · 0e8b3cdf
      Evgeny Yakovlev 提交于
      mmap man page:
      "On success, mmap() returns a pointer to the mapped area. On error, the
      value MAP_FAILED (that is, (void *) -1) is returned, and errno  is  set
      to indicate the cause of the error."
      
      The check in postcopy_get_tmp_page is definitely wrong and should be
      fixed.
      Signed-off-by: NEvgeny Yakovlev <eyakovlev@virtuozzo.com>
      Signed-off-by: NDenis V. Lunev <den@openvz.org>
      Reviewed-by: NAmit Shah <amit.shah@redhat.com>
      Reviewed-by: NDr. David Alan Gilbert <dgilbert@redhat.com>
      CC: Juan Quintela <quintela@redhat.com>
      CC: Amit Shah <amit.shah@redhat.com>
      Message-Id: <1469785705-16670-1-git-send-email-den@openvz.org>
      Signed-off-by: NAmit Shah <amit.shah@redhat.com>
      0e8b3cdf
    • C
      migration/ram: fix typo · e110aa91
      Cao jin 提交于
      Signed-off-by: NCao jin <caoj.fnst@cn.fujitsu.com>
      Message-Id: <1469776231-23820-1-git-send-email-caoj.fnst@cn.fujitsu.com>
      Signed-off-by: NAmit Shah <amit.shah@redhat.com>
      e110aa91
    • D
      virtio-console: set frontend open permanently for console devs · bce6261e
      Daniel P. Berrange 提交于
      The virtio-console.c file handles both serial consoles
      and interactive consoles, since they're backed by the
      same device model.
      
      Since serial devices are expected to be reliable and
      need to notify the guest when the backend is opened
      or closed, the virtio-console.c file wires up support
      for chardev events. This affects both serial consoles
      and interactive consoles, using a network connection
      based chardev backend such as 'socket', but not when
      using a PTY based backend or plain 'file' backends.
      
      When the host side is not connected the handle_output()
      method in virtio-serial-bus.c will drop any data sent
      by the guest, before it even reaches the virtio-console.c
      code. This means that if the chardev has a logfile
      configured, the data will never get logged.
      
      Consider for example, configuring a x86_64 guest with a
      plain UART serial port
      
        -chardev socket,id=charserial1,host=127.0.0.1,port=9001,server,nowait,logfile=console1.log,logappend=on
        -device isa-serial,chardev=charserial1,id=serial1
      
      vs a s390 guest which has to use the virtio-console port
      
        -chardev socket,id=charconsole1,host=127.0.0.1,port=9000,server,nowait,logfile=console2.log,logappend=on
        -device virtconsole,chardev=charconsole1,id=console1
      
      The isa-serial one gets data written to the log regardless
      of whether a client is connected, while the virtioconsole
      one only gets data written to the log when a client is
      connected.
      
      There is no need for virtio-serial-bus.c to aggressively
      drop the data for console devices, as the chardev code is
      prefectly capable of discarding the data itself.
      
      So this patch changes virtconsole devices so that they
      are always marked as having the host side open. This
      ensures that the guest OS will always send any data it
      has (Linux virtio-console hvc driver actually ignores
      the host open state and sends data regardless, but we
      should not rely on that), and also prevents the
      virtio-serial-bus code prematurely discarding data.
      
      The behaviour of virtserialport devices is *not* changed,
      only virtconsole, because for the former, it is important
      that the guest OSknow exactly when the host side is opened
      / closed so it can do any protocol re-negotiation that may
      be required.
      
      Fixes bug: https://bugs.launchpad.net/qemu/+bug/1599214Acked-by: NCornelia Huck <cornelia.huck@de.ibm.com>
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      Message-Id: <1470241360-3574-2-git-send-email-berrange@redhat.com>
      Signed-off-by: NAmit Shah <amit.shah@redhat.com>
      bce6261e
    • P
      Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging · 144a6db0
      Peter Maydell 提交于
      # gpg: Signature made Thu 11 Aug 2016 11:35:33 BST
      # gpg:                using RSA key 0x9CA4ABB381AB73C8
      # gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>"
      # gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>"
      # Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8
      
      * remotes/stefanha/tags/block-pull-request:
        linux-aio: Handle io_submit() failure gracefully
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      144a6db0
    • K
      linux-aio: Handle io_submit() failure gracefully · 44713c9e
      Kevin Wolf 提交于
      It is generally not expected that io_submit() fails other than with
      -EAGAIN, but corner cases like SELinux refusing I/O when permissions are
      revoked are still possible. In this case, we shouldn't abort, but just
      return an I/O error for the request.
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      Message-id: 1470741619-23231-1-git-send-email-kwolf@redhat.com
      Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      44713c9e
    • P
      Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging · d08306dc
      Peter Maydell 提交于
      virtio/vhost: fixes
      
      some bugfixes for virtio/vhost
      Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
      
      # gpg: Signature made Wed 10 Aug 2016 16:16:22 BST
      # gpg:                using RSA key 0x281F0DB8D28D5469
      # gpg: Good signature from "Michael S. Tsirkin <mst@kernel.org>"
      # gpg:                 aka "Michael S. Tsirkin <mst@redhat.com>"
      # Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
      #      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469
      
      * remotes/mst/tags/for_upstream:
        vhost-user: Attempt to fix a race with set_mem_table.
        vhost-user: Introduce a new protocol feature REPLY_ACK.
        vhost: check for vhost_ops before using.
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      d08306dc
  6. 10 8月, 2016 4 次提交
    • P
      Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging · 4b3e5c06
      Peter Maydell 提交于
      * pc-bios/optionrom/Makefile fixes
      * warning fixes for __atomic_load and -1 << x in clang
      * missed interrupt fix from Gonglei
      * checkpatch fix from Radim and myself
      
      # gpg: Signature made Wed 10 Aug 2016 14:54:31 BST
      # gpg:                using RSA key 0xBFFBD25F78C7AE83
      # gpg: Good signature from "Paolo Bonzini <bonzini@gnu.org>"
      # gpg:                 aka "Paolo Bonzini <pbonzini@redhat.com>"
      # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
      #      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83
      
      * remotes/bonzini/tags/for-upstream:
        checkpatch: default to success if only warnings
        checkpatch: bump most warnings to errors
        CODING_STYLE, checkpatch: update line length rules
        checkpatch: check for CVS keywords on all sources
        checkpatch: tweak the files in which TABs are checked
        timer: set vm_clock disabled default
        checkpatch: ignore automatically imported Linux headers
        clang: Fix warning reg. expansion to 'defined'
        Disable warn about left shifts of negative values
        atomic: strip "const" from variables declared with typeof
        optionrom: fix compilation with mingw docker target
        optionrom: add -fno-stack-protector
        build-sys: fix building with make CFLAGS=.. argument
        linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      4b3e5c06
    • P
      vhost-user: Attempt to fix a race with set_mem_table. · 28ed5ef1
      Prerna Saxena 提交于
      The set_mem_table command currently does not seek a reply. Hence, there is
      no easy way for a remote application to notify to QEMU when it finished
      setting up memory, or if there were errors doing so.
      
      As an example:
      (1) Qemu sends a SET_MEM_TABLE to the backend (eg, a vhost-user net
      application). SET_MEM_TABLE does not require a reply according to the spec.
      (2) Qemu commits the memory to the guest.
      (3) Guest issues an I/O operation over a new memory region which was configured on (1).
      (4) The application has not yet remapped the memory, but it sees the I/O request.
      (5) The application cannot satisfy the request because it does not know about those GPAs.
      
      While a guaranteed fix would require a protocol extension (committed separately),
      a best-effort workaround for existing applications is to send a GET_FEATURES
      message before completing the vhost_user_set_mem_table() call.
      Since GET_FEATURES requires a reply, an application that processes vhost-user
      messages synchronously would probably have completed the SET_MEM_TABLE before replying.
      Signed-off-by: NPrerna Saxena <prerna.saxena@nutanix.com>
      Reviewed-by: NMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
      28ed5ef1
    • P
      vhost-user: Introduce a new protocol feature REPLY_ACK. · ca525ce5
      Prerna Saxena 提交于
      This introduces the VHOST_USER_PROTOCOL_F_REPLY_ACK.
      
      If negotiated, client applications should send a u64 payload in
      response to any message that contains the "need_reply" bit set
      on the message flags. Setting the payload to "zero" indicates the
      command finished successfully. Likewise, setting it to "non-zero"
      indicates an error.
      
      Currently implemented only for SET_MEM_TABLE.
      Reviewed-by: NMarc-André Lureau <marcandre.lureau@redhat.com>
      Signed-off-by: NPrerna Saxena <prerna.saxena@nutanix.com>
      Reviewed-by: NMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
      ca525ce5
    • I
      vhost: check for vhost_ops before using. · ca10203c
      Ilya Maximets 提交于
      'vhost_set_vring_enable()' tries to call function using pointer to
      'vhost_ops' which can be already zeroized in 'vhost_dev_cleanup()'
      while vhost disconnection.
      
      Fix that by checking 'vhost_ops' before using. This fixes QEMU crash
      on calling 'ethtool -L eth0 combined 2' if vhost disconnected.
      Signed-off-by: NIlya Maximets <i.maximets@samsung.com>
      Reviewed-by: NMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
      ca10203c