1. 20 2月, 2018 7 次提交
  2. 19 2月, 2018 16 次提交
  3. 17 2月, 2018 4 次提交
  4. 16 2月, 2018 13 次提交
    • P
      Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180216-pull-request' into staging · 5e8d6a12
      Peter Maydell 提交于
      bugfixes for vnc and sdl2
      
      # gpg: Signature made Fri 16 Feb 2018 11:53:37 GMT
      # gpg:                using RSA key 4CB6D8EED3E87138
      # gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>"
      # gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>"
      # gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>"
      # Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138
      
      * remotes/kraxel/tags/ui-20180216-pull-request:
        ui: extend VNC trottling tracing to SASL codepaths
        ui: check VNC audio frequency limit at time of reading from client
        ui: avoid 'local_err' variable shadowing in VNC SASL auth
        ui: avoid risk of 32-bit int overflow in VNC buffer check
        sdl2: fix mouse grab
        sdl: restore optimized redraw
        vnc: fix segfault in closed connection handling
        vnc: add qapi/error.h include to stubs
        vnc: remove bogus object_unref on client socket
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      5e8d6a12
    • P
      Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.12-20180216' into staging · d9c92ae3
      Peter Maydell 提交于
      ppc patch queue 2018-02-16
      
      Highlights of this batch:
        * Conversion to TranslatorOps (Emilio Cota)
        * Further bugfixes and cleanups to vcpu id allocation for pseries
          (Greg Kurz)
        * Another bugfix for HPT resizing (Daniel Henrique-Barboza)
        * Macintosh CUDA cleanups (Mark Cave-Ayland)
        * Further tweaks to Spectre/Meltdown mitigations (Suraj Singh)
      
      # gpg: Signature made Fri 16 Feb 2018 10:00:02 GMT
      # gpg:                using RSA key 6C38CACA20D9B392
      # gpg: Good signature from "David Gibson <david@gibson.dropbear.id.au>"
      # gpg:                 aka "David Gibson (Red Hat) <dgibson@redhat.com>"
      # gpg:                 aka "David Gibson (ozlabs.org) <dgibson@ozlabs.org>"
      # gpg:                 aka "David Gibson (kernel.org) <dwg@kernel.org>"
      # Primary key fingerprint: 75F4 6586 AE61 A66C C44E  87DC 6C38 CACA 20D9 B392
      
      * remotes/dgibson/tags/ppc-for-2.12-20180216:
        ppc4xx: Add device models found in PPC440 core SoCs
        ppc/spapr-caps: Disallow setting workaround for spapr-cap-ibs
        target/ppc: convert to TranslatorOps
        target/ppc: convert to DisasContextBase
        spapr: consolidate the VCPU id numbering logic in a single place
        spapr: rename spapr_vcpu_id() to spapr_get_vcpu_id()
        spapr: move VCPU calculation to core machine code
        spapr: use spapr->vsmt to compute VCPU ids
        ppc/spapr-caps: Change migration macro to take full spapr-cap name
        hw/char: remove legacy interface escc_init()
        hw/ppc/spapr_hcall: set htab_shift after kvmppc_resize_hpt_commit
        cuda: convert to trace-events
        ppc: move CUDAState and other CUDA-related definitions into separate cuda.h file
        cuda: convert to use the shared mos6522 device
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      d9c92ae3
    • P
      Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20180214a' into staging · 648ba915
      Peter Maydell 提交于
      Migration pull 20180214
      
      Note that the 'Add test for migration to bad destination' displays
      a 'Connection refused' during running, but still gives the correct exit
      code and OK (It's checking that the source doesn't fail when
      it can't connect, so that's the right error).
      If it's particularly disliked that patch can be skipped individually.
      
      # gpg: Signature made Wed 14 Feb 2018 15:33:04 GMT
      # gpg:                using RSA key 0516331EBC5BFDE7
      # gpg: Good signature from "Dr. David Alan Gilbert (RH2) <dgilbert@redhat.com>"
      # Primary key fingerprint: 45F5 C71B 4A0C B7FB 977A  9FA9 0516 331E BC5B FDE7
      
      * remotes/dgilbert/tags/pull-migration-20180214a:
        migration: pass MigrationState to migrate_init()
        migration: allow send_rq to fail
        migration: provide postcopy_fault_thread_notify()
        migration: reuse mis->userfault_quit_fd
        migration: better error handling with QEMUFile
        tests/migration: Add test for migration to bad destination
        migration: Fix early failure cleanup
        tests/migration: Add source to PC boot block
        migration: improve documentation of postcopy-ram
        migration/xen: Check return value of qemu_fclose
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      648ba915
    • D
      ui: extend VNC trottling tracing to SASL codepaths · d50f09ff
      Daniel P. Berrangé 提交于
      In previous commit:
      
        commit 6aa22a29
        Author: Daniel P. Berrange <berrange@redhat.com>
        Date:   Mon Dec 18 19:12:27 2017 +0000
      
          ui: add trace events related to VNC client throttling
      
      trace points related to unthrottling client I/O were missed from the
      SASL codepaths.
      Reported-by: NLaszlo Ersek <lersek@redhat.com>
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      Reviewed-by: NLaszlo Ersek <lersek@redhat.com>
      Message-id: 20180205114938.15784-5-berrange@redhat.com
      Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      d50f09ff
    • D
      ui: check VNC audio frequency limit at time of reading from client · cf070658
      Daniel P. Berrangé 提交于
      The 'vs->as.freq' value is a signed integer, which is read from an
      unsigned 32-bit int field on the wire. There is thus a risk of overflow
      on 32-bit platforms. Move the frequency limit checking to be done at
      time of read before casting to a signed integer.
      Reported-by: NLaszlo Ersek <lersek@redhat.com>
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      Reviewed-by: NLaszlo Ersek <lersek@redhat.com>
      Reviewed-by: NPhilippe Mathieu-Daudé <f4bug@amsat.org>
      Message-id: 20180205114938.15784-4-berrange@redhat.com
      Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      cf070658
    • D
      ui: avoid 'local_err' variable shadowing in VNC SASL auth · 52c7c9d0
      Daniel P. Berrangé 提交于
      The start_auth_sasl() method declares a 'Error *local_err' variable in
      an inner if () {...} scope, which shadows a variable of the same name
      declared at the start of the method. This is confusing for reviewers and
      may trigger compiler warnings.
      Reported-by: NLaszlo Ersek <lersek@redhat.com>
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      Reviewed-by: NLaszlo Ersek <lersek@redhat.com>
      Reviewed-by: NPhilippe Mathieu-Daudé <f4bug@amsat.org>
      Message-id: 20180205114938.15784-3-berrange@redhat.com
      Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      52c7c9d0
    • D
      ui: avoid risk of 32-bit int overflow in VNC buffer check · dffa1de0
      Daniel P. Berrangé 提交于
      For very large framebuffers, it is theoretically possible for the result
      of 'vs->throttle_output_offset * VNC_THROTTLE_OUTPUT_LIMIT_SCALE' to
      exceed the size of a 32-bit int. For this to happen in practice, the
      video RAM would have to be set to a large enough value, which is not
      likely today. None the less we can be paranoid against future growth by
      using division instead of multiplication when checking the limits.
      Reported-by: NLaszlo Ersek <lersek@redhat.com>
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      Reviewed-by: NLaszlo Ersek <lersek@redhat.com>
      Reviewed-by: NPhilippe Mathieu-Daudé <f4bug@amsat.org>
      Message-id: 20180205114938.15784-2-berrange@redhat.com
      Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      dffa1de0
    • G
      sdl2: fix mouse grab · 8dfa3061
      Gerd Hoffmann 提交于
      When qemu mouse mode changes from relative to absolute
      we must turn off sdl relative mouse mode too.
      
      Fixes: https://bugs.launchpad.net/qemu/+bug/1703795Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      Message-Id: <20180202120803.11501-1-kraxel@redhat.com>
      8dfa3061
    • A
      sdl: restore optimized redraw · 2ab858c6
      Anatoly Trosinenko 提交于
      The documentation on SDL_RenderPresent function states that
      "the backbuffer should be considered invalidated after each present",
      so copy the entire texture on each redraw.
      
      On the other hand, SDL_UpdateTexture function is described as
      "fairly slow function", so restrict it to just the changed pixels.
      
      Also added SDL_RenderClear call, as suggested in the documentation
      page on SDL_RenderPresent.
      Signed-off-by: NAnatoly Trosinenko <anatoly.trosinenko@gmail.com>
      Message-id: 20180205133228.25082-1-anatoly.trosinenko@gmail.com
      Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      2ab858c6
    • K
      vnc: fix segfault in closed connection handling · d49b87f0
      Klim Kireev 提交于
      On one of our client's node, due to trying to read from closed ioc,
      a segmentation fault occured. Corresponding backtrace:
      
      0  object_get_class (obj=obj@entry=0x0)
      1  qio_channel_readv_full (ioc=0x0, iov=0x7ffe55277180 ...
      2  qio_channel_read (ioc=<optimized out> ...
      3  vnc_client_read_buf (vs=vs@entry=0x55625f3c6000, ...
      4  vnc_client_read_plain (vs=0x55625f3c6000)
      5  vnc_client_read (vs=0x55625f3c6000)
      6  vnc_client_io (ioc=<optimized out>, condition=G_IO_IN, ...
      7  g_main_dispatch (context=0x556251568a50)
      8  g_main_context_dispatch (context=context@entry=0x556251568a50)
      9  glib_pollfds_poll ()
      10 os_host_main_loop_wait (timeout=<optimized out>)
      11 main_loop_wait (nonblocking=nonblocking@entry=0)
      12 main_loop () at vl.c:1909
      13 main (argc=<optimized out>, argv=<optimized out>, ...
      
      Having analyzed the coredump, I understood that the reason is that
      ioc_tag is reset on vnc_disconnect_start and ioc is cleaned
      in vnc_disconnect_finish. Between these two events due to some
      reasons the ioc_tag was set again and after vnc_disconnect_finish
      the handler is running with freed ioc,
      which led to the segmentation fault.
      
      The patch checks vs->disconnecting in places where we call
      qio_channel_add_watch and resets handler if disconnecting == TRUE
      to prevent such an occurrence.
      Signed-off-by: NKlim Kireev <klim.kireev@virtuozzo.com>
      Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com>
      Message-id: 20180207094844.21402-1-klim.kireev@virtuozzo.com
      Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      d49b87f0
    • G
      vnc: add qapi/error.h include to stubs · 577ce409
      Gerd Hoffmann 提交于
      Fixes --disable-vnc build failure.
      Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      Reviewed-by: NEric Blake <eblake@redhat.com>
      Message-id: 20180213070526.22475-1-kraxel@redhat.com
      577ce409
    • D
      vnc: remove bogus object_unref on client socket · f42fdb24
      Daniel P. Berrangé 提交于
      vnc_listen_io() does not own the reference on the 'cioc' parameter is it
      passed, so should not be unref'ing it.
      
      Fixes: 13e1d0e7Reported-by: NBandan Das <bsd@redhat.com>
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      Reviewed-by: NEric Blake <eblake@redhat.com>
      Message-id: 20180215102602.10864-1-berrange@redhat.com
      Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      f42fdb24
    • P
      Merge remote-tracking branch 'remotes/berrange/tags/qio-next-pull-request' into staging · 0402ca3c
      Peter Maydell 提交于
      # gpg: Signature made Thu 15 Feb 2018 17:50:22 GMT
      # gpg:                using RSA key BE86EBB415104FDF
      # gpg: Good signature from "Daniel P. Berrange <dan@berrange.com>"
      # gpg:                 aka "Daniel P. Berrange <berrange@redhat.com>"
      # Primary key fingerprint: DAF3 A6FD B26B 6291 2D0E  8E3F BE86 EBB4 1510 4FDF
      
      * remotes/berrange/tags/qio-next-pull-request:
        allow to build with older sed
        io/channel-command: Do not kill the child process after closing the pipe
        io: Add /dev/fdset/ support to QIOChannelFile
        io: Don't call close multiple times in QIOChannelFile
        io: Fix QIOChannelFile when creating and opening read-write
        io/channel-websock: handle continuous reads without any data
        io: fix QIONetListener memory leak
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      0402ca3c