提交 fd39941a 编写于 作者: A Avi Kivity 提交者: Blue Swirl

Fix off-by-one in dirty bitmap functions

Reported-by: NStefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>
上级 9ec032d2
...@@ -83,9 +83,10 @@ static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, ...@@ -83,9 +83,10 @@ static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start,
uint8_t *p; uint8_t *p;
ram_addr_t addr, end; ram_addr_t addr, end;
end = start + length; end = TARGET_PAGE_ALIGN(start + length);
start &= TARGET_PAGE_MASK;
p = ram_list.phys_dirty + (start >> TARGET_PAGE_BITS); p = ram_list.phys_dirty + (start >> TARGET_PAGE_BITS);
for (addr = start; addr <= end; addr += TARGET_PAGE_SIZE) { for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
*p++ |= dirty_flags; *p++ |= dirty_flags;
} }
} }
...@@ -98,10 +99,11 @@ static inline void cpu_physical_memory_mask_dirty_range(ram_addr_t start, ...@@ -98,10 +99,11 @@ static inline void cpu_physical_memory_mask_dirty_range(ram_addr_t start,
uint8_t *p; uint8_t *p;
ram_addr_t addr, end; ram_addr_t addr, end;
end = start + length; end = TARGET_PAGE_ALIGN(start + length);
start &= TARGET_PAGE_MASK;
mask = ~dirty_flags; mask = ~dirty_flags;
p = ram_list.phys_dirty + (start >> TARGET_PAGE_BITS); p = ram_list.phys_dirty + (start >> TARGET_PAGE_BITS);
for (addr = start; addr <= end; addr += TARGET_PAGE_SIZE) { for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
*p++ &= mask; *p++ &= mask;
} }
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册