提交 fa876bc9 编写于 作者: P Paolo Bonzini 提交者: Michael Roth

address_space_access_valid: address_space_to_flatview needs RCU lock

address_space_access_valid is calling address_space_to_flatview but it can
be called outside the RCU lock.  To fix it, push the rcu_read_lock/unlock
pair up from flatview_access_valid to address_space_access_valid.
Reviewed-by: NAlexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 11e732a5)
Signed-off-by: NMichael Roth <mdroth@linux.vnet.ibm.com>
上级 f77c2312
...@@ -3322,7 +3322,6 @@ static bool flatview_access_valid(FlatView *fv, hwaddr addr, int len, ...@@ -3322,7 +3322,6 @@ static bool flatview_access_valid(FlatView *fv, hwaddr addr, int len,
MemoryRegion *mr; MemoryRegion *mr;
hwaddr l, xlat; hwaddr l, xlat;
rcu_read_lock();
while (len > 0) { while (len > 0) {
l = len; l = len;
mr = flatview_translate(fv, addr, &xlat, &l, is_write); mr = flatview_translate(fv, addr, &xlat, &l, is_write);
...@@ -3337,15 +3336,20 @@ static bool flatview_access_valid(FlatView *fv, hwaddr addr, int len, ...@@ -3337,15 +3336,20 @@ static bool flatview_access_valid(FlatView *fv, hwaddr addr, int len,
len -= l; len -= l;
addr += l; addr += l;
} }
rcu_read_unlock();
return true; return true;
} }
bool address_space_access_valid(AddressSpace *as, hwaddr addr, bool address_space_access_valid(AddressSpace *as, hwaddr addr,
int len, bool is_write) int len, bool is_write)
{ {
return flatview_access_valid(address_space_to_flatview(as), FlatView *fv;
addr, len, is_write); bool result;
rcu_read_lock();
fv = address_space_to_flatview(as);
result = flatview_access_valid(fv, addr, len, is_write);
rcu_read_unlock();
return result;
} }
static hwaddr static hwaddr
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册