提交 f8ad4a89 编写于 作者: A Aneesh Kumar K.V

hw/9pfs: Use little-endian format for xattr values

With security_model=mapped-xattr, we encode the uid,gid and other file
attributes as extended attributes of the file. We save them under
user.virtfs.* namespace.

Use little-endian encoding for on-disk values. This enables us to export
the same directory from both little-endian and big-endian hosts.

NOTE: This will break big-endian host that have virtFS exports
using security model mapped-xattr. They will have to use external tools
to convert the xattr to little-endian format.
Signed-off-by: NAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
上级 30eaca3a
...@@ -135,17 +135,17 @@ static int local_lstat(FsContext *fs_ctx, V9fsPath *fs_path, struct stat *stbuf) ...@@ -135,17 +135,17 @@ static int local_lstat(FsContext *fs_ctx, V9fsPath *fs_path, struct stat *stbuf)
mode_t tmp_mode; mode_t tmp_mode;
dev_t tmp_dev; dev_t tmp_dev;
if (getxattr(buffer, "user.virtfs.uid", &tmp_uid, sizeof(uid_t)) > 0) { if (getxattr(buffer, "user.virtfs.uid", &tmp_uid, sizeof(uid_t)) > 0) {
stbuf->st_uid = tmp_uid; stbuf->st_uid = le32_to_cpu(tmp_uid);
} }
if (getxattr(buffer, "user.virtfs.gid", &tmp_gid, sizeof(gid_t)) > 0) { if (getxattr(buffer, "user.virtfs.gid", &tmp_gid, sizeof(gid_t)) > 0) {
stbuf->st_gid = tmp_gid; stbuf->st_gid = le32_to_cpu(tmp_gid);
} }
if (getxattr(buffer, "user.virtfs.mode", if (getxattr(buffer, "user.virtfs.mode",
&tmp_mode, sizeof(mode_t)) > 0) { &tmp_mode, sizeof(mode_t)) > 0) {
stbuf->st_mode = tmp_mode; stbuf->st_mode = le32_to_cpu(tmp_mode);
} }
if (getxattr(buffer, "user.virtfs.rdev", &tmp_dev, sizeof(dev_t)) > 0) { if (getxattr(buffer, "user.virtfs.rdev", &tmp_dev, sizeof(dev_t)) > 0) {
stbuf->st_rdev = tmp_dev; stbuf->st_rdev = le64_to_cpu(tmp_dev);
} }
} else if (fs_ctx->export_flags & V9FS_SM_MAPPED_FILE) { } else if (fs_ctx->export_flags & V9FS_SM_MAPPED_FILE) {
local_mapped_file_attr(fs_ctx, path, stbuf); local_mapped_file_attr(fs_ctx, path, stbuf);
...@@ -255,29 +255,29 @@ static int local_set_xattr(const char *path, FsCred *credp) ...@@ -255,29 +255,29 @@ static int local_set_xattr(const char *path, FsCred *credp)
int err; int err;
if (credp->fc_uid != -1) { if (credp->fc_uid != -1) {
err = setxattr(path, "user.virtfs.uid", &credp->fc_uid, sizeof(uid_t), uint32_t tmp_uid = cpu_to_le32(credp->fc_uid);
0); err = setxattr(path, "user.virtfs.uid", &tmp_uid, sizeof(uid_t), 0);
if (err) { if (err) {
return err; return err;
} }
} }
if (credp->fc_gid != -1) { if (credp->fc_gid != -1) {
err = setxattr(path, "user.virtfs.gid", &credp->fc_gid, sizeof(gid_t), uint32_t tmp_gid = cpu_to_le32(credp->fc_gid);
0); err = setxattr(path, "user.virtfs.gid", &tmp_gid, sizeof(gid_t), 0);
if (err) { if (err) {
return err; return err;
} }
} }
if (credp->fc_mode != -1) { if (credp->fc_mode != -1) {
err = setxattr(path, "user.virtfs.mode", &credp->fc_mode, uint32_t tmp_mode = cpu_to_le32(credp->fc_mode);
sizeof(mode_t), 0); err = setxattr(path, "user.virtfs.mode", &tmp_mode, sizeof(mode_t), 0);
if (err) { if (err) {
return err; return err;
} }
} }
if (credp->fc_rdev != -1) { if (credp->fc_rdev != -1) {
err = setxattr(path, "user.virtfs.rdev", &credp->fc_rdev, uint64_t tmp_rdev = cpu_to_le64(credp->fc_rdev);
sizeof(dev_t), 0); err = setxattr(path, "user.virtfs.rdev", &tmp_rdev, sizeof(dev_t), 0);
if (err) { if (err) {
return err; return err;
} }
...@@ -630,21 +630,17 @@ static int local_fstat(FsContext *fs_ctx, int fid_type, ...@@ -630,21 +630,17 @@ static int local_fstat(FsContext *fs_ctx, int fid_type,
mode_t tmp_mode; mode_t tmp_mode;
dev_t tmp_dev; dev_t tmp_dev;
if (fgetxattr(fd, "user.virtfs.uid", if (fgetxattr(fd, "user.virtfs.uid", &tmp_uid, sizeof(uid_t)) > 0) {
&tmp_uid, sizeof(uid_t)) > 0) { stbuf->st_uid = le32_to_cpu(tmp_uid);
stbuf->st_uid = tmp_uid;
} }
if (fgetxattr(fd, "user.virtfs.gid", if (fgetxattr(fd, "user.virtfs.gid", &tmp_gid, sizeof(gid_t)) > 0) {
&tmp_gid, sizeof(gid_t)) > 0) { stbuf->st_gid = le32_to_cpu(tmp_gid);
stbuf->st_gid = tmp_gid;
} }
if (fgetxattr(fd, "user.virtfs.mode", if (fgetxattr(fd, "user.virtfs.mode", &tmp_mode, sizeof(mode_t)) > 0) {
&tmp_mode, sizeof(mode_t)) > 0) { stbuf->st_mode = le32_to_cpu(tmp_mode);
stbuf->st_mode = tmp_mode;
} }
if (fgetxattr(fd, "user.virtfs.rdev", if (fgetxattr(fd, "user.virtfs.rdev", &tmp_dev, sizeof(dev_t)) > 0) {
&tmp_dev, sizeof(dev_t)) > 0) { stbuf->st_rdev = le64_to_cpu(tmp_dev);
stbuf->st_rdev = tmp_dev;
} }
} else if (fs_ctx->export_flags & V9FS_SM_MAPPED_FILE) { } else if (fs_ctx->export_flags & V9FS_SM_MAPPED_FILE) {
errno = EOPNOTSUPP; errno = EOPNOTSUPP;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册