提交 c6fcc10a 编写于 作者: L Luiz Capitulino 提交者: Michael Roth

qemu-ga: guest-suspend-disk: don't emit a success response

Today, qemu-ga may not be able to emit a success response when
guest-suspend-disk completes. This happens because the VM may
vanish before qemu-ga is able to emit a response.

This semantic is a bit confusing, as it's not clear for clients if
they should wait for a response or how they should check for success.

This commit solves that problem by changing guest-suspend-disk to
never emit a success response and suggests in the documentation
what clients could do to check for success.
Signed-off-by: NLuiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: NMichael Roth <mdroth@linux.vnet.ibm.com>
上级 89268172
...@@ -363,17 +363,21 @@ ...@@ -363,17 +363,21 @@
# For the best results it's strongly recommended to have the pm-utils # For the best results it's strongly recommended to have the pm-utils
# package installed in the guest. # package installed in the guest.
# #
# Returns: nothing on success # This command does NOT return a response on success. There is a high chance
# the command succeeded if the VM exits with a zero exit status or, when
# running with --no-shutdown, by issuing the query-status QMP command to
# to confirm the VM status is "shutdown". However, the VM could also exit
# (or set its status to "shutdown") due to other reasons.
#
# The following errors may be returned:
# If suspend to disk is not supported, Unsupported # If suspend to disk is not supported, Unsupported
# #
# Notes: o This is an asynchronous request. There's no guarantee a response # Notes: It's strongly recommended to issue the guest-sync command before
# will be sent # sending commands when the guest resumes
# o It's strongly recommended to issue the guest-sync command before
# sending commands when the guest resumes
# #
# Since: 1.1 # Since: 1.1
## ##
{ 'command': 'guest-suspend-disk' } { 'command': 'guest-suspend-disk', 'success-response': 'no' }
## ##
# @guest-suspend-ram # @guest-suspend-ram
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册