提交 8b34a9db 编写于 作者: E Eric Blake 提交者: Paolo Bonzini

nbd: Refactor conversion to errno to silence checkpatch

Checkpatch complains that 'return EINVAL' is usually wrong
(since we tend to favor 'return -EINVAL').  But it is a
false positive for nbd_errno_to_system_errno().  Since NBD
may add future defined wire values, refactor the code to
keep checkpatch happy.
Signed-off-by: NEric Blake <eblake@redhat.com>
Message-Id: <1476469998-28592-14-git-send-email-eblake@redhat.com>
Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
上级 c203c59a
......@@ -23,23 +23,31 @@
static int nbd_errno_to_system_errno(int err)
{
int ret;
switch (err) {
case NBD_SUCCESS:
return 0;
ret = 0;
break;
case NBD_EPERM:
return EPERM;
ret = EPERM;
break;
case NBD_EIO:
return EIO;
ret = EIO;
break;
case NBD_ENOMEM:
return ENOMEM;
ret = ENOMEM;
break;
case NBD_ENOSPC:
return ENOSPC;
ret = ENOSPC;
break;
default:
TRACE("Squashing unexpected error %d to EINVAL", err);
/* fallthrough */
case NBD_EINVAL:
return EINVAL;
ret = EINVAL;
break;
}
return ret;
}
/* Definitions for opaque data types */
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册