提交 810f4f86 编写于 作者: F Fam Zheng 提交者: Stefan Hajnoczi

nfs: Fix leak of opts in nfs_file_open

Signed-off-by: NFam Zheng <famz@redhat.com>
Reviewed-by: NBenoît Canet <benoit.canet@nodalink.com>
Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
上级 a2f468e4
...@@ -393,16 +393,20 @@ static int nfs_file_open(BlockDriverState *bs, QDict *options, int flags, ...@@ -393,16 +393,20 @@ static int nfs_file_open(BlockDriverState *bs, QDict *options, int flags,
qemu_opts_absorb_qdict(opts, options, &local_err); qemu_opts_absorb_qdict(opts, options, &local_err);
if (local_err) { if (local_err) {
error_propagate(errp, local_err); error_propagate(errp, local_err);
return -EINVAL; ret = -EINVAL;
goto out;
} }
ret = nfs_client_open(client, qemu_opt_get(opts, "filename"), ret = nfs_client_open(client, qemu_opt_get(opts, "filename"),
(flags & BDRV_O_RDWR) ? O_RDWR : O_RDONLY, (flags & BDRV_O_RDWR) ? O_RDWR : O_RDONLY,
errp); errp);
if (ret < 0) { if (ret < 0) {
return ret; goto out;
} }
bs->total_sectors = ret; bs->total_sectors = ret;
return 0; ret = 0;
out:
qemu_opts_del(opts);
return ret;
} }
static int nfs_file_create(const char *url, QemuOpts *opts, Error **errp) static int nfs_file_create(const char *url, QemuOpts *opts, Error **errp)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册