提交 5a371a2e 编写于 作者: J Jan Kiszka

slirp: Fix types of IP address parameters

Should be uint32_t for IPv4, not int. Also avoid in_addr_t without
proper includes. Fixes build regression on mingw32.
Signed-off-by: NJan Kiszka <jan.kiszka@siemens.com>
上级 81e34a24
...@@ -24,9 +24,9 @@ ...@@ -24,9 +24,9 @@
#include "slirp.h" #include "slirp.h"
void arp_table_add(Slirp *slirp, int ip_addr, uint8_t ethaddr[ETH_ALEN]) void arp_table_add(Slirp *slirp, uint32_t ip_addr, uint8_t ethaddr[ETH_ALEN])
{ {
const in_addr_t broadcast_addr = const uint32_t broadcast_addr =
~slirp->vnetwork_mask.s_addr | slirp->vnetwork_addr.s_addr; ~slirp->vnetwork_mask.s_addr | slirp->vnetwork_addr.s_addr;
ArpTable *arptbl = &slirp->arp_table; ArpTable *arptbl = &slirp->arp_table;
int i; int i;
...@@ -60,29 +60,29 @@ void arp_table_add(Slirp *slirp, int ip_addr, uint8_t ethaddr[ETH_ALEN]) ...@@ -60,29 +60,29 @@ void arp_table_add(Slirp *slirp, int ip_addr, uint8_t ethaddr[ETH_ALEN])
arptbl->next_victim = (arptbl->next_victim + 1) % ARP_TABLE_SIZE; arptbl->next_victim = (arptbl->next_victim + 1) % ARP_TABLE_SIZE;
} }
bool arp_table_search(Slirp *slirp, int in_ip_addr, bool arp_table_search(Slirp *slirp, uint32_t ip_addr,
uint8_t out_ethaddr[ETH_ALEN]) uint8_t out_ethaddr[ETH_ALEN])
{ {
const in_addr_t broadcast_addr = const uint32_t broadcast_addr =
~slirp->vnetwork_mask.s_addr | slirp->vnetwork_addr.s_addr; ~slirp->vnetwork_mask.s_addr | slirp->vnetwork_addr.s_addr;
ArpTable *arptbl = &slirp->arp_table; ArpTable *arptbl = &slirp->arp_table;
int i; int i;
DEBUG_CALL("arp_table_search"); DEBUG_CALL("arp_table_search");
DEBUG_ARG("ip = 0x%x", in_ip_addr); DEBUG_ARG("ip = 0x%x", ip_addr);
/* Check 0.0.0.0/8 invalid source-only addresses */ /* Check 0.0.0.0/8 invalid source-only addresses */
assert((in_ip_addr & htonl(~(0xf << 28))) != 0); assert((ip_addr & htonl(~(0xf << 28))) != 0);
/* If broadcast address */ /* If broadcast address */
if (in_ip_addr == 0xffffffff || in_ip_addr == broadcast_addr) { if (ip_addr == 0xffffffff || ip_addr == broadcast_addr) {
/* return Ethernet broadcast address */ /* return Ethernet broadcast address */
memset(out_ethaddr, 0xff, ETH_ALEN); memset(out_ethaddr, 0xff, ETH_ALEN);
return 1; return 1;
} }
for (i = 0; i < ARP_TABLE_SIZE; i++) { for (i = 0; i < ARP_TABLE_SIZE; i++) {
if (arptbl->table[i].ar_sip == in_ip_addr) { if (arptbl->table[i].ar_sip == ip_addr) {
memcpy(out_ethaddr, arptbl->table[i].ar_sha, ETH_ALEN); memcpy(out_ethaddr, arptbl->table[i].ar_sha, ETH_ALEN);
DEBUG_ARGS((dfd, " found hw addr = %02x:%02x:%02x:%02x:%02x:%02x\n", DEBUG_ARGS((dfd, " found hw addr = %02x:%02x:%02x:%02x:%02x:%02x\n",
out_ethaddr[0], out_ethaddr[1], out_ethaddr[2], out_ethaddr[0], out_ethaddr[1], out_ethaddr[2],
......
...@@ -208,9 +208,9 @@ typedef struct ArpTable { ...@@ -208,9 +208,9 @@ typedef struct ArpTable {
int next_victim; int next_victim;
} ArpTable; } ArpTable;
void arp_table_add(Slirp *slirp, int ip_addr, uint8_t ethaddr[ETH_ALEN]); void arp_table_add(Slirp *slirp, uint32_t ip_addr, uint8_t ethaddr[ETH_ALEN]);
bool arp_table_search(Slirp *slirp, int in_ip_addr, bool arp_table_search(Slirp *slirp, uint32_t ip_addr,
uint8_t out_ethaddr[ETH_ALEN]); uint8_t out_ethaddr[ETH_ALEN]);
struct Slirp { struct Slirp {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册