提交 451b9e2d 编写于 作者: C Cornelia Huck 提交者: Michael Roth

virtio: fix feature bit checks

Several places check against the feature bit number instead of against
the feature bit. Fix them.

Cc: qemu-stable@nongnu.org
Reported-by: NThomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: NCornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: NMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 91d5c57a)
Signed-off-by: NMichael Roth <mdroth@linux.vnet.ibm.com>
上级 0d093159
...@@ -144,7 +144,7 @@ static int virtio_scsi_parse_req(VirtIOSCSIReq *req, ...@@ -144,7 +144,7 @@ static int virtio_scsi_parse_req(VirtIOSCSIReq *req,
* *
* TODO: always disable this workaround for virtio 1.0 devices. * TODO: always disable this workaround for virtio 1.0 devices.
*/ */
if ((vdev->guest_features & VIRTIO_F_ANY_LAYOUT) == 0) { if ((vdev->guest_features & (1 << VIRTIO_F_ANY_LAYOUT)) == 0) {
req_size = req->elem.out_sg[0].iov_len; req_size = req->elem.out_sg[0].iov_len;
resp_size = req->elem.in_sg[0].iov_len; resp_size = req->elem.in_sg[0].iov_len;
} }
......
...@@ -133,12 +133,12 @@ bool vring_should_notify(VirtIODevice *vdev, Vring *vring) ...@@ -133,12 +133,12 @@ bool vring_should_notify(VirtIODevice *vdev, Vring *vring)
* interrupts. */ * interrupts. */
smp_mb(); smp_mb();
if ((vdev->guest_features & VIRTIO_F_NOTIFY_ON_EMPTY) && if ((vdev->guest_features & (1 << VIRTIO_F_NOTIFY_ON_EMPTY)) &&
unlikely(vring->vr.avail->idx == vring->last_avail_idx)) { unlikely(vring->vr.avail->idx == vring->last_avail_idx)) {
return true; return true;
} }
if (!(vdev->guest_features & VIRTIO_RING_F_EVENT_IDX)) { if (!(vdev->guest_features & (1 << VIRTIO_RING_F_EVENT_IDX))) {
return !(vring->vr.avail->flags & VRING_AVAIL_F_NO_INTERRUPT); return !(vring->vr.avail->flags & VRING_AVAIL_F_NO_INTERRUPT);
} }
old = vring->signalled_used; old = vring->signalled_used;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册