提交 3ce21445 编写于 作者: J Jincheng Miao 提交者: Gerd Hoffmann

usb: initialize libusb_device to avoid crash

If libusb_get_device_list() fails, the uninitialized local variable
libusb_device would be passed to libusb_free_device_list(), that
will cause a crash, like:
(gdb) bt
 #0  0x00007fbbb4bafc10 in pthread_mutex_lock () from /lib64/libpthread.so.0
 #1  0x00007fbbb233e653 in libusb_unref_device (dev=0x6275682d627375)
     at core.c:902
 #2  0x00007fbbb233e739 in libusb_free_device_list (list=0x7fbbb6e8436e,
     unref_devices=<optimized out>) at core.c:653
 #3  0x00007fbbb6cd80a4 in usb_host_auto_check (unused=unused@entry=0x0)
     at hw/usb/host-libusb.c:1446
 #4  0x00007fbbb6cd8525 in usb_host_initfn (udev=0x7fbbbd3c5670)
     at hw/usb/host-libusb.c:912
 #5  0x00007fbbb6cc123b in usb_device_init (dev=0x7fbbbd3c5670)
     at hw/usb/bus.c:106
 ...

So initialize libusb_device at the begin time.
Signed-off-by: NJincheng Miao <jmiao@redhat.com>
Reviewed-by: NGonglei <arei.gonglei@huawei.com>
Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
上级 c340a284
...@@ -1522,7 +1522,7 @@ static void usb_host_auto_check(void *unused) ...@@ -1522,7 +1522,7 @@ static void usb_host_auto_check(void *unused)
{ {
struct USBHostDevice *s; struct USBHostDevice *s;
struct USBAutoFilter *f; struct USBAutoFilter *f;
libusb_device **devs; libusb_device **devs = NULL;
struct libusb_device_descriptor ddesc; struct libusb_device_descriptor ddesc;
int unconnected = 0; int unconnected = 0;
int i, n; int i, n;
...@@ -1623,7 +1623,7 @@ static void usb_host_auto_check(void *unused) ...@@ -1623,7 +1623,7 @@ static void usb_host_auto_check(void *unused)
void usb_host_info(Monitor *mon, const QDict *qdict) void usb_host_info(Monitor *mon, const QDict *qdict)
{ {
libusb_device **devs; libusb_device **devs = NULL;
struct libusb_device_descriptor ddesc; struct libusb_device_descriptor ddesc;
char port[16]; char port[16];
int i, n; int i, n;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册