• L
    ohci: delay first SOF interrupt · fd0a10cd
    Laurent Vivier 提交于
    On overcommitted CPU, kernel can be so slow that an interrupt can
    be triggered by the device whereas the driver is not ready to receive
    it. This drives us into an infinite loop.
    
    This does not happen on real hardware because real hardware never send
    interrupt immediately after the controller has been moved to OPERATION state.
    
    This patch tries to delay the first SOF interrupt to let driver exits from
    the critical section (which is not protected against interrupts...)
    
    Some details:
    
    - ohci_irq(): the OHCI interrupt handler, acknowledges the SOF IRQ
      only if the state of the driver (rh_state) is OHCI_STATE_RUNNING.
      So if this interrupt happens and the driver is not in this state,
      the function is called again and again, moving the system to a
      CPU starvation.
    
    - ohci_rh_resume(): the driver re-enables operation with OHCI_USB_OPER.
      In QEMU this start the SOF timer and QEMU starts to send IRQs. As
      the driver is not in OHCI_STATE_RUNNING and not protected against IRQ,
      the ohci_irq() can be called and the driver never moved to
      OHCI_STATE_RUNNING.
    Suggested-by: NGerd Hoffmann <kraxel@redhat.com>
    Signed-off-by: NLaurent Vivier <lvivier@redhat.com>
    Reviewed-by: NThomas Huth <thuth@redhat.com>
    Message-id: 1452109525-32150-2-git-send-email-lvivier@redhat.com
    Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
    fd0a10cd
hcd-ohci.c 60.8 KB