• M
    qapi: Simplify error reporting for array types · eddf817b
    Markus Armbruster 提交于
    check_type() first checks and peels off the array type, then checks
    the element type.  For two out of four error messages, it takes pains
    to report errors for "array of T" instead of just T.  Odd.  Let's
    examine the errors.
    
    * Unknown element type, e.g.
      tests/qapi-schema/args-array-unknown.json:
    
          Member 'array' of 'data' for command 'oops' uses unknown type
          'array of NoSuchType'
    
      To make sense of this, you need to know that 'array of NoSuchType'
      refers to '[NoSuchType]'.  Easy enough.  However, simply reporting
    
          Member 'array' of 'data' for command 'oops' uses unknown type
          'NoSuchType'
    
      is at least as easy to understand.
    
    * Element type's meta-type is inadmissible, e.g.
      tests/qapi-schema/returns-whitelist.json:
    
          'returns' for command 'no-way-this-will-get-whitelisted' cannot
          use built-in type 'array of int'
    
      'array of int' is technically not a built-in type, but that's
      pedantry.  However, simply reporting
    
          'returns' for command 'no-way-this-will-get-whitelisted' cannot
          use built-in type 'int'
    
      avoids the issue, and is at least as easy to understand.
    
    * The remaining two errors are unreachable, because the array checking
      ensures that value is a string.
    
    Thus, reporting some errors for "array of T" instead of just T works,
    but doesn't really improve things.  Drop it.
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: NEric Blake <eblake@redhat.com>
    eddf817b
args-array-unknown.err 120 字节