• M
    qga: Clean up unnecessarily dirty casts · e7cf59e8
    Markus Armbruster 提交于
    qga_vss_fsfreeze() casts error_set_win32() from
    
        void (*)(Error **, int, ErrorClass, const char *, ...)
    
    to
    
        void (*)(void **, int, int, const char *, ...)
    
    The result is later called.  Since the two types are not compatible,
    the call is undefined behavior.  It works in practice anyway.
    
    However, there's no real need for trickery here.  Clean it up as
    follows:
    
    * Declare struct Error, and fix the first parameter.
    
    * Switch to error_setg_win32().  This gets rid of the troublesome
      ErrorClass parameter.  Requires converting error_setg_win32() from
      macro to function, but that's trivially easy, because this is the
      only user of error_set_win32().
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: NEric Blake <eblake@redhat.com>
    e7cf59e8
vss-win32.c 4.4 KB