• A
    block: Make bdrv_root_attach_child() unref child_bs on failure · b441dc71
    Alberto Garcia 提交于
    A consequence of the previous patch is that bdrv_attach_child()
    transfers the reference to child_bs from the caller to parent_bs,
    which will drop it on bdrv_close() or when someone calls
    bdrv_unref_child().
    
    But this only happens when bdrv_attach_child() succeeds. If it fails
    then the caller is responsible for dropping the reference to child_bs.
    
    This patch makes bdrv_attach_child() take the reference also when
    there is an error, freeing the caller for having to do it.
    
    A similar situation happens with bdrv_root_attach_child(), so the
    changes on this patch affect both functions.
    Signed-off-by: NAlberto Garcia <berto@igalia.com>
    Message-id: 20dfb3d9ccec559cdd1a9690146abad5d204a186.1557754872.git.berto@igalia.com
    [mreitz: Removed now superfluous BdrvChild * variable in
             bdrv_open_child()]
    Signed-off-by: NMax Reitz <mreitz@redhat.com>
    b441dc71
blockjob.c 14.7 KB