• M
    error: Use error_prepend() where it makes obvious sense · e43bfd9c
    Markus Armbruster 提交于
    Done with this Coccinelle semantic patch
    
        @@
        expression FMT, E1, E2;
        expression list ARGS;
        @@
        -    error_setg(E1, FMT, ARGS, error_get_pretty(E2));
        +    error_propagate(E1, E2);/*###*/
        +    error_prepend(E1, FMT/*@@@*/, ARGS);
    
    followed by manual cleanup, first because I can't figure out how to
    make Coccinelle transform strings, and second to get rid of now
    superfluous error_propagate().
    
    We now use or propagate the original error whole instead of just its
    message obtained with error_get_pretty().  This avoids suppressing its
    hint (see commit 50b7b000), but I can't see how the errors touched in
    this commit could come with hints.  It also improves the message
    printed with &error_abort when we screw up (see commit 1e9b65bb).
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: NEric Blake <eblake@redhat.com>
    e43bfd9c
qcow2.c 107.3 KB