• M
    qapi: Clean up modular built-in code generation a bit · dcac6471
    Markus Armbruster 提交于
    We neglect to call .visit_module() for the special module we use for
    built-ins.  Harmless, but clean it up anyway.  The
    tests/qapi-schema/*.out now show the built-in module as 'module None'.
    
    Subclasses of QAPISchemaModularCVisitor need to ._add_module() this
    special module to enable code generation for built-ins.  When this
    hasn't been done, QAPISchemaModularCVisitor.visit_module() does
    nothing for the special module.  That looks like built-ins could
    accidentally be generated into the wrong module when a subclass
    neglects to call ._add_module().  Can't happen, because built-ins are
    all visited before any other module.  But that's non-obvious.  Switch
    off code generation explicitly.
    
    Rename QAPISchemaModularCVisitor._begin_module() to
    ._begin_user_module().
    
    New QAPISchemaModularCVisitor._is_builtin_module(), for clarity.
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: NMarc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20190214152251.2073-4-armbru@redhat.com>
    dcac6471
common.py 81.6 KB