• V
    nbd: rename read_sync and friends · d1fdf257
    Vladimir Sementsov-Ogievskiy 提交于
    Rename
      nbd_wr_syncv -> nbd_rwv
      read_sync -> nbd_read
      read_sync_eof -> nbd_read_eof
      write_sync -> nbd_write
      drop_sync -> nbd_drop
    
    1. nbd_ prefix
       read_sync and write_sync are already shared, so it is good to have a
       namespace prefix. drop_sync will be shared, and read_sync_eof is
       related to read_sync, so let's rename them all.
    
    2. _sync suffix
       _sync is related to the fact that nbd_wr_syncv doesn't return if a
       write to socket returns EAGAIN. The first implementation of
       nbd_wr_syncv (was wr_sync in 7a5ca864) just loops while getting
       EAGAIN, the current implementation yields in this case.
       Why we want to get rid of it:
       - it is normal for r/w functions to be synchronous, so having an
         additional suffix for it looks redundant (contrariwise, we have
         _aio suffix for async functions)
       - _sync suffix in block layer is used when function does flush (so
         using it for other thing is confusing a bit)
       - keep function names short after adding nbd_ prefix
    
    3. for nbd_wr_syncv let's use more common notation 'rw'
    Reviewed-by: NEric Blake <eblake@redhat.com>
    Signed-off-by: NVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20170602150150.258222-2-vsementsov@virtuozzo.com>
    Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
    d1fdf257
server.c 39.0 KB