• M
    virtio-bus: Plug devices after features are negotiated · d1b4259f
    Maxime Coquelin 提交于
    Currently, devices are plugged before features are negotiated.
    If the backend doesn't support VIRTIO_F_VERSION_1, the transport
    needs to rewind some settings.
    
    This is the case for CCW, for which a post_plugged callback had
    been introduced, where max_rev field is just updated if
    VIRTIO_F_VERSION_1 is not supported by the backend.
    For PCI, implementing post_plugged would be much more
    complicated, so it needs to know whether the backend supports
    VIRTIO_F_VERSION_1 at plug time.
    
    Currently, nothing is done for PCI. Modern capabilities get
    exposed to the guest even if VIRTIO_F_VERSION_1 is not supported
    by the backend, which confuses the guest.
    
    This patch replaces existing post_plugged solution with an
    approach that fits with both transports.
    Features negotiation is performed before ->device_plugged() call.
    A pre_plugged callback is introduced so that the transports can
    set their supported features.
    
    Cc: Michael S. Tsirkin <mst@redhat.com>
    Cc: qemu-stable@nongnu.org
    Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com> [ccw]
    Reviewed-by: NCornelia Huck <cornelia.huck@de.ibm.com>
    Reviewed-by: NMarcel Apfelbaum <marcel@redhat.com>
    Signed-off-by: NMaxime Coquelin <maxime.coquelin@redhat.com>
    d1b4259f
virtio-pci.h 9.2 KB