• E
    qmp-input: Require struct push to visit members of top dict · ce140b17
    Eric Blake 提交于
    Don't embed the root of the visit into the stack of current
    containers being visited.  That way, we no longer get confused
    on whether the first visit of a dictionary is to the dictionary
    itself or to one of the members of the dictionary, based on
    whether the caller passed name=NULL; and makes the QMP Input
    visitor like other visitors where the value of 'name' is now
    ignored on the root visit.  (We may someday want to revisit
    the rules on what 'name' should be on a top-level visit,
    rather than just ignoring it; but that would be the topic of
    another patch).
    
    An audit of all qmp_input_visitor_new() call sites shows that
    there were only two places where callers had previously been
    visiting to a QDict with a non-NULL name to bypass a call to
    visit_start_struct(), and those were fixed in prior patches.
    Signed-off-by: NEric Blake <eblake@redhat.com>
    Message-Id: <1461879932-9020-11-git-send-email-eblake@redhat.com>
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    ce140b17
qmp-input-visitor.c 9.8 KB