• D
    target-i386: fix typo in xsetbv implementation · ba03584f
    Dave Hansen 提交于
    QEMU 2.6 added support for the XSAVE family of instructions, which
    includes the XSETBV instruction which allows setting the XCR0
    register.
    
    But, when booting Linux kernels with XSAVE support enabled, I was
    getting very early crashes where the instruction pointer was set
    to 0x3.  I tracked it down to a jump instruction generated by this:
    
            gen_jmp_im(s->pc - pc_start);
    
    where s->pc is pointing to the instruction after XSETBV and pc_start
    is pointing _at_ XSETBV.  Subtract the two and you get 0x3.  Whoops.
    
    The fix is to replace this typo with the pattern found everywhere
    else in the file when folks want to end the translation buffer.
    
    Richard Henderson confirmed that this is a bug and that this is the
    correct fix.
    Signed-off-by: NDave Hansen <dave.hansen@linux.intel.com>
    Cc: qemu-stable@nongnu.org
    Cc: Eduardo Habkost <ehabkost@redhat.com>
    Reviewed-by: NRichard Henderson <rth@twiddle.net>
    Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
    ba03584f
translate.c 282.2 KB