• P
    qemu-sockets: fix conversion of ipv4/ipv6 JSON to QemuOpts · b77e7c8e
    Paolo Bonzini 提交于
    The QemuOpts-based code treats "option not set" and "option set
    to false" the same way for the ipv4 and ipv6 options, because it
    is meant to handle only the ",ipv4" and ",ipv6" substrings in
    hand-crafted option parsers.
    
    When converting InetSocketAddress to QemuOpts, however, it is
    necessary to handle all three cases (not set, set to true, set
    to false).  Currently we are not handling all cases correctly.
    The rules are:
    
    * if none or both options are absent, leave things as is
    
    * if the single present option is Y, the other should be N.
    This can be implemented by leaving things as is, or by setting
    the other option to N as done in this patch.
    
    * if the single present option is N, the other should be Y.
    This is handled by the "else if" branch of this patch.
    
    This ensures that the ipv4 option has an effect on Windows,
    where creating the socket with PF_UNSPEC makes an ipv6
    socket.  With this patch, ",ipv4" will result in a PF_INET
    socket instead.
    Reported-by: NSair, Umair <Umair_Sair@mentor.com>
    Tested-by: NSair, Umair <Umair_Sair@mentor.com>
    Reviewed-by: NDaniel P. Berrange <berrange@redhat.com>
    Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
    b77e7c8e
qemu-sockets.c 28.2 KB