• V
    block: drop bs->job · b23c580c
    Vladimir Sementsov-Ogievskiy 提交于
    Drop remaining users of bs->job:
    1. assertions actually duplicated by assert(!bs->refcnt)
    2. trace-point seems not enough reason to change stream_start to return
       BlockJob pointer
    3. Restricting creation of two jobs based on same bs is bad idea, as
       3.1 Some jobs creates filters to be their main node, so, this check
       don't actually prevent creating second job on same real node (which
       will create another filter node) (but I hope it is restricted by
       other mechanisms)
       3.2 Even without bs->job we have two systems of permissions:
       op-blockers and BLK_PERM
       3.3 We may want to run several jobs on one node one day
    
    And finally, drop bs->job pointer itself. Hurrah!
    Suggested-by: NKevin Wolf <kwolf@redhat.com>
    Signed-off-by: NVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Signed-off-by: NKevin Wolf <kwolf@redhat.com>
    b23c580c
block_int.h 52.5 KB