• M
    mmap-alloc: fix hugetlbfs misaligned length in ppc64 · 53adb9d4
    Murilo Opsfelder Araujo 提交于
    The commit 7197fb40 ("util/mmap-alloc:
    fix hugetlb support on ppc64") fixed Huge TLB mappings on ppc64.
    
    However, we still need to consider the underlying huge page size
    during munmap() because it requires that both address and length be a
    multiple of the underlying huge page size for Huge TLB mappings.
    Quote from "Huge page (Huge TLB) mappings" paragraph under NOTES
    section of the munmap(2) manual:
    
      "For munmap(), addr and length must both be a multiple of the
      underlying huge page size."
    
    On ppc64, the munmap() in qemu_ram_munmap() does not work for Huge TLB
    mappings because the mapped segment can be aligned with the underlying
    huge page size, not aligned with the native system page size, as
    returned by getpagesize().
    
    This has the side effect of not releasing huge pages back to the pool
    after a hugetlbfs file-backed memory device is hot-unplugged.
    
    This patch fixes the situation in qemu_ram_mmap() and
    qemu_ram_munmap() by considering the underlying page size on ppc64.
    
    After this patch, memory hot-unplug releases huge pages back to the
    pool.
    
    Fixes: 7197fb40Signed-off-by: NMurilo Opsfelder Araujo <muriloo@linux.ibm.com>
    Reviewed-by: NGreg Kurz <groug@kaod.org>
    Signed-off-by: NDavid Gibson <david@gibson.dropbear.id.au>
    53adb9d4
oslib-posix.c 18.3 KB