• E
    target-i386: Don't set any KVM flag by default if KVM is disabled · aa87d458
    Eduardo Habkost 提交于
    This is a cleanup that tries to solve two small issues:
    
     - We don't need a separate kvm_pv_eoi_features variable just to keep a
       constant calculated at compile-time, and this style would require
       adding a separate variable (that's declared twice because of the
       CONFIG_KVM ifdef) for each feature that's going to be
       enabled/disabled by machine-type compat code.
     - The pc-1.3 code is setting the kvm_pv_eoi flag on cpuid_kvm_features
       even when KVM is disabled at runtime. This small inconsistency in
       the cpuid_kvm_features field isn't a problem today because
       cpuid_kvm_features is ignored by the TCG code, but it may cause
       unexpected problems later when refactoring the CPUID handling code.
    
    This patch eliminates the kvm_pv_eoi_features variable and simply uses
    kvm_enabled() inside the enable_kvm_pv_eoi() compat function, so it
    enables kvm_pv_eoi only if KVM is enabled. I believe this makes the
    behavior of enable_kvm_pv_eoi() clearer and easier to understand.
    Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>
    Acked-by: NGleb Natapov <gleb@redhat.com>
    Reviewed-by: NMarcelo Tosatti <mtosatti@redhat.com>
    Signed-off-by: NAndreas Färber <afaerber@suse.de>
    aa87d458
cpu.c 76.4 KB