• V
    arm/translate-a64: treat DISAS_UPDATE as variant of DISAS_EXIT · a75a52d6
    Victor Kamensky 提交于
    In OE project 4.15 linux kernel boot hang was observed under
    single cpu aarch64 qemu. Kernel code was in a loop waiting for
    vtimer arrival, spinning in TC generated blocks, while interrupt
    was pending unprocessed. This happened because when qemu tried to
    handle vtimer interrupt target had interrupts disabled, as
    result flag indicating TCG exit, cpu->icount_decr.u16.high,
    was cleared but arm_cpu_exec_interrupt function did not call
    arm_cpu_do_interrupt to process interrupt. Later when target
    reenabled interrupts, it happened without exit into main loop, so
    following code that waited for result of interrupt execution
    run in infinite loop.
    
    To solve the problem instructions that operate on CPU sys state
    (i.e enable/disable interrupt), and marked as DISAS_UPDATE,
    should be considered as DISAS_EXIT variant, and should be
    forced to exit back to main loop so qemu will have a chance
    processing pending CPU state updates, including pending
    interrupts.
    
    This change brings consistency with how DISAS_UPDATE is treated
    in aarch32 case.
    
    CC: Peter Maydell <peter.maydell@linaro.org>
    CC: Alex Bennée <alex.bennee@linaro.org>
    CC: qemu-stable@nongnu.org
    Suggested-by: NPeter Maydell <peter.maydell@linaro.org>
    Signed-off-by: NVictor Kamensky <kamensky@cisco.com>
    Reviewed-by: NRichard Henderson <richard.henderson@linaro.org>
    Message-id: 1521526368-1996-1-git-send-email-kamensky@cisco.com
    Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
    a75a52d6
translate-a64.c 416.9 KB