• P
    virtio-blk: always enable VIRTIO_BLK_F_SCSI · a6c5c84a
    Paolo Bonzini 提交于
    VIRTIO_BLK_F_SCSI is supposed to mean whether the host can *parse*
    SCSI requests, not *execute* them.  You could run QEMU with scsi=on
    and a file-backed disk, and QEMU would fail all SCSI requests even
    though it advertises VIRTIO_BLK_F_SCSI.
    
    Because we need to do this to fix a migration compatibility problem
    related to how QEMU is invoked by management, we must do this
    unconditionally even on older machine types.  This more or less assumes
    that no one ever invoked QEMU with scsi=off.
    
    Here is how testing goes:
    
    - old QEMU, scsi=on -> new QEMU, scsi=on
    - new QEMU, scsi=on -> old QEMU, scsi=on
    - old QEMU, scsi=off -> new QEMU, scsi=on
    - new QEMU, scsi=off -> old QEMU, scsi=on
            ok (new QEMU has VIRTIO_BLK_F_SCSI, adding host features is fine)
    
    - old QEMU, scsi=off -> new QEMU, scsi=off
            ok (new QEMU has VIRTIO_BLK_F_SCSI, adding host features is fine)
    
    - old QEMU, scsi=on -> new QEMU, scsi=off
            ok, bug fixed
    
    - new QEMU, scsi=on -> old QEMU, scsi=off
            doesn't work (same as: old QEMU, scsi=on -> old QEMU, scsi=off)
    
    - new QEMU, scsi=off -> old QEMU, scsi=off
            broken by the patch
    Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>
    a6c5c84a
virtio-blk.c 16.9 KB