• E
    qapi: Simplify error cleanup in test-qmp-* · a12a5a1a
    Eric Blake 提交于
    We have several tests that perform multiple sub-actions that are
    expected to fail.  Asserting that an error occurred, then clearing
    it up to prepare for the next action, turned into enough
    boilerplate that it was sometimes forgotten (for example, a number
    of tests added to test-qmp-input-visitor.c in d88f5fd1 leaked err).
    Worse, if an error is not reset to NULL, we risk invalidating
    later use of that error (passing a non-NULL err into a function
    is generally a bad idea).  Encapsulate the boilerplate into a
    single helper function error_free_or_abort(), and consistently
    use it.
    
    The new function is added into error.c for use everywhere,
    although it is anticipated that testsuites will be the main
    client.
    Signed-off-by: NEric Blake <eblake@redhat.com>
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    a12a5a1a
test-qmp-input-strict.c 10.9 KB