• E
    nbd-client: Short-circuit 0-length operations · 9d8f818c
    Eric Blake 提交于
    The NBD spec was recently clarified to state that clients should
    not send 0-length requests to the server, as the server behavior
    is undefined [1].  We know that qemu-nbd's behavior is a successful
    no-op (once it has filtered for read-only exports), but other NBD
    implementations might return an error.  To avoid any questionable
    server implementations, it is better to just short-circuit such
    requests on the client side (we are relying on the block layer to
    already filter out requests such as invalid offset, write to a
    read-only volume, and so forth); do the short-circuit as late as
    possible to still benefit from protections from assertions that
    the block layer is not violating our assumptions.
    
    [1] https://github.com/NetworkBlockDevice/nbd/commit/ee926037Signed-off-by: NEric Blake <eblake@redhat.com>
    Message-Id: <20171108215703.9295-6-eblake@redhat.com>
    Reviewed-by: NVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    9d8f818c
nbd-client.c 24.9 KB