• J
    block: update string sizes for filename,backing_file,exact_filename · 9a29e18f
    Jeff Cody 提交于
    The string field entries 'filename', 'backing_file', and
    'exact_filename' in the BlockDriverState struct are defined as 1024
    bytes.
    
    However, many places that use these values accept a maximum of PATH_MAX
    bytes, so we have a mixture of 1024 byte and PATH_MAX byte allocations.
    This patch makes the BlockDriverStruct field string sizes match usage.
    
    This patch also does a few fixes related to the size that needs to
    happen now:
    
        * the block qapi driver is updated to use PATH_MAX bytes
        * the qcow and qcow2 drivers have an additional safety check
        * the block vvfat driver is updated to use PATH_MAX bytes
          for the size of backing_file, for systems where PATH_MAX is < 1024
          bytes.
        * qemu-img uses PATH_MAX rather than 1024.  These instances were not
          changed to be dynamically allocated, however, as the extra
          temporary 3K in stack usage for qemu-img does not seem worrisome.
    Reviewed-by: NStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: NJohn Snow <jsnow@redhat.com>
    Signed-off-by: NJeff Cody <jcody@redhat.com>
    Signed-off-by: NKevin Wolf <kwolf@redhat.com>
    9a29e18f
block_int.h 23.7 KB