• E
    qapi: Fix command with named empty argument type · 972a1101
    Eric Blake 提交于
    The generator special-cased
    
     { 'command':'foo', 'data': {} }
    
    to avoid emitting a visitor variable, but failed to see that
    
     { 'struct':'NamedEmptyType, 'data': {} }
     { 'command':'foo', 'data':'NamedEmptyType' }
    
    needs the same treatment.  There, the generator happily generates a
    visitor to get no arguments, and a visitor to destroy no arguments;
    and the compiler isn't happy with that, as demonstrated by the updated
    qapi-schema-test.json:
    
      tests/test-qmp-marshal.c: In function ‘qmp_marshal_user_def_cmd0’:
      tests/test-qmp-marshal.c:264:14: error: variable ‘v’ set but not used [-Werror=unused-but-set-variable]
           Visitor *v;
                    ^
    
    No change to generated code except for the testsuite addition.
    Signed-off-by: NEric Blake <eblake@redhat.com>
    Message-Id: <1458254921-17042-3-git-send-email-eblake@redhat.com>
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    972a1101
qapi-commands.py 7.7 KB