• D
    qapi: Rewrite string-input-visitor's integer and list parsing · c9fba9de
    David Hildenbrand 提交于
    The input visitor has some problems right now, especially
    - unsigned type "Range" is used to process signed ranges, resulting in
      inconsistent behavior and ugly/magical code
    - uint64_t are parsed like int64_t, so big uint64_t values are not
      supported and error messages are misleading
    - lists/ranges of int64_t are accepted although no list is parsed and
      we should rather report an error
    - lists/ranges are preparsed using int64_t, making it hard to
      implement uint64_t values or uint64_t lists
    - types that don't support lists don't bail out
    - visiting beyond the end of a list is not handled properly
    - we don't actually parse lists, we parse *sets*: members are sorted,
      and duplicates eliminated
    
    So let's rewrite it by getting rid of usage of the type "Range" and
    properly supporting lists of int64_t and uint64_t (including ranges of
    both types), fixing the above mentioned issues.
    
    Lists of other types are not supported and will properly report an
    error. Virtual walks are now supported.
    
    Tests have to be fixed up:
    - Two BUGs were hardcoded that are fixed now
    - The string-input-visitor now actually returns a parsed list and not
      an ordered set.
    
    Please note that no users/callers have to be fixed up. Candidates using
    visit_type_uint16List() and friends are:
    - backends/hostmem.c:host_memory_backend_set_host_nodes()
    -- Code can deal with duplicates/unsorted lists
    - numa.c::query_memdev()
    -- via object_property_get_uint16List(), the list will still be sorted
       and without duplicates (via host_memory_backend_get_host_nodes())
    - qapi-visit.c::visit_type_Memdev_members()
    - qapi-visit.c::visit_type_NumaNodeOptions_members()
    - qapi-visit.c::visit_type_RockerOfDpaGroup_members
    - qapi-visit.c::visit_type_RxFilterInfo_members()
    -- Not used with string-input-visitor.
    Reviewed-by: NEric Blake <eblake@redhat.com>
    Reviewed-by: NMarkus Armbruster <armbru@redhat.com>
    Signed-off-by: NDavid Hildenbrand <david@redhat.com>
    Message-Id: <20181121164421.20780-7-david@redhat.com>
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    c9fba9de
string-input-visitor.h 664 字节