• E
    qapi: Simplify use of range.h · 7c47959d
    Eric Blake 提交于
    Calling our function g_list_insert_sorted_merged is a misnomer,
    since we are NOT writing a glib function.  Furthermore, we are
    making every caller pass the same comparator function of
    range_merge(): any caller that would try otherwise would break
    in weird ways since our internal call to ranges_can_merge() is
    hard-coded to operate only on ranges, rather than paying
    attention to the caller's comparator.
    
    Better is to fix things so that callers don't have to care about
    our internal comparator, by picking a function name and updating
    the parameter type away from a gratuitous use of void*, to make
    it obvious that we are operating specifically on a list of ranges
    and not a generic list.  Plus, refactoring the code here will
    make it easier to plug a memory leak in the next patch.
    
    range_compare() is now internal only, and moves to the .c file.
    Signed-off-by: NEric Blake <eblake@redhat.com>
    Message-Id: <1464712890-14262-3-git-send-email-eblake@redhat.com>
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    7c47959d
range.c 2.4 KB