• M
    block/mirror: Fix use-after-free · 7a25fcd0
    Max Reitz 提交于
    If @bs does not have any parents, the only reference to @mirror_top_bs
    will be held by the BlockJob object after the bdrv_unref() following
    block_job_create(). However, if block_job_create() fails, this reference
    will not exist and @mirror_top_bs will have been deleted when we
    goto fail.
    
    The issue comes back at all later entries to the fail label: We delete
    the BlockJob object before rolling back our changes to the node graph.
    This means that we will delete @mirror_top_bs in the process.
    
    All in all, whenever @bs does not have any parents and we go down the
    fail path we will dereference @mirror_top_bs after it has been deleted.
    
    Fix this by invoking bdrv_unref() only when block_job_create() was
    successful and by bdrv_ref()'ing @mirror_top_bs in the fail path before
    deleting the BlockJob object. Finally, bdrv_unref() it at the end of the
    fail path after we actually no longer need it.
    Signed-off-by: NMax Reitz <mreitz@redhat.com>
    Reviewed-by: NJohn Snow <jsnow@redhat.com>
    Reviewed-by: NPhilippe Mathieu-Daudé <f4bug@amsat.org>
    Signed-off-by: NKevin Wolf <kwolf@redhat.com>
    7a25fcd0
mirror.c 44.5 KB