• E
    qapi: Use generated TestStruct machinery in tests · 748053c9
    Eric Blake 提交于
    Commit d88f5fd1 and friends first introduced the various test-qmp-*
    tests in 2011, with duplicated hand-rolled TestStruct machinery,
    to make sure the qapi visitor interface was tested.  Later, commit
    4f193e34 in 2013 added a .json file for further testing use by the
    files, but without consolidating any of the existing hand-rolled
    visitors.  And with four copies, subtle differences have crept in,
    between the tests themselves (mainly whitespace differences, but
    also a question of whether to use NULL or "TestStruct" when
    calling visit_start_struct()) and from what the generator produces
    (the hand-rolled versions did not cater to partially-allocated
    objects, because they did not have a deallocation usage).
    
    Of course, just because the visitor interface is tested does not
    mean it is a sane interface; and future patches will be changing
    some of the visitor contracts.  Rather than having to duplicate
    the cleanup work in each copy of the TestStruct visitor, and keep
    each hand-rolled copy in sync with what the generator supplies, we
    might as well just test what the generator should give us in the
    first place.
    Signed-off-by: NEric Blake <eblake@redhat.com>
    Message-Id: <1446791754-23823-2-git-send-email-eblake@redhat.com>
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    748053c9
test-qmp-input-strict.c 11.0 KB