• D
    qga: removing bios_supports_mode · 73e1d8eb
    Daniel Henrique Barboza 提交于
    bios_support_mode verifies if the guest has support for a certain
    suspend mode but it doesn't inform back which suspend tool
    provides it. The caller, guest_suspend, executes all suspend
    strategies in order again.
    
    After adding systemd suspend support, bios_support_mode now will
    verify for support for systemd, then pmutils, then Linux sys state
    file. In a worst case scenario where both systemd and pmutils isn't
    supported but Linux sys state is:
    
    - bios_supports_mode will check for systemd, then pmutils, then
    Linux sys state. It will tell guest_suspend that there is support,
    but it will not tell who provides it;
    
    - guest_suspend will try to execute (and fail) systemd suspend,
    then pmutils suspend, to only then use the Linux sys suspend.
    The time spent executing systemd and pmutils suspend was wasted
    and could be avoided, but only bios_support_mode knew it but
    didn't inform it back.
    
    A quicker approach is to nuke bios_supports_mode and control
    whether we found support at all with a bool flag inside
    guest_suspend. guest_suspend will search for suspend support
    and execute it as soon as possible. If the a given suspend
    mechanism fails, continue to the next. If no suspend
    support is found, the "not supported" message is still being
    sent back to the user.
    Signed-off-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
    Signed-off-by: NMichael Roth <mdroth@linux.vnet.ibm.com>
    73e1d8eb
commands-posix.c 80.4 KB