• G
    fw_cfg: replace ioport data read with generic method · 6c8d56a2
    Gabriel L. Somlo 提交于
    IOPort read access is limited to one byte at a time by
    fw_cfg_comb_valid(). As such, fw_cfg_comb_read() may safely
    ignore its size argument (which will always be 1), and simply
    call its fw_cfg_read() helper function once, returning 8 bits
    via the least significant byte of a 64-bit return value.
    
    This patch replaces fw_cfg_comb_read() with the generic method
    fw_cfg_data_read(), and removes the unused fw_cfg_read() helper.
    
    When called with size = 1, fw_cfg_data_read() acts exactly like
    fw_cfg_read(), performing the same set of sanity checks, and
    executing the while loop at most once (subject to the current
    read offset being within range).
    
    Cc: Laszlo Ersek <lersek@redhat.com>
    Cc: Gerd Hoffmann <kraxel@redhat.com>
    Cc: Marc Marí <markmb@redhat.com>
    Signed-off-by: NGabriel Somlo <somlo@cmu.edu>
    Message-id: 1446733972-1602-7-git-send-email-somlo@cmu.edu
    Reviewed-by: NLaszlo Ersek <lersek@redhat.com>
    Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
    6c8d56a2
fw_cfg.c 27.8 KB